RTC bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar tecpromotion
tecpromotion
9 Sep 2026

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

AI disclosure: root cause analysis and patch were done with the help of Claude Code. I reviewed the change and tested it manually on a local installation, before and after, as described below.

Summary of Changes

The menu and toolbar buttons in the TinyMCE set builder (System → Plugins → Editor - TinyMCE) are always displayed in English, no matter which administrator language is used.

The language file itself is loaded correctly, media/vendor/tinymce/langs/<lang>.min.js is in the page source. But it has no effect:

  • media_source/plg_editors_tinymce/js/tinymce-builder.es6.js replaces the global tinymce object with its own small stub (langCode: 'en', langStrings: {}) which only provides addI18n(), translate() and showIcon().
  • The builder script is registered as type="module", the language script as defer. Module scripts and deferred classic scripts run in document order, and the layout emits the language script first. So addI18n() is called on the real TinyMCE object, and a moment later that object is thrown away and replaced by the stub with its empty langStrings.

The fix registers the language script as depending on the builder script, so the web asset manager emits it after the builder script. Then addI18n() reaches the stub, and since the builder renders on DOMContentLoaded (later than both scripts), the strings are in place when the buttons are created.

One line changed in layouts/plugins/editors/tinymce/field/tinymcebuilder.php.

Note: the same problem exists in 6.x. There it needs a second change on top of this one (the field looks for .min.js language files, which the new build system no longer produces), see the companion PR for 6.2-dev.

Testing Instructions

  1. Install a non-English language pack, e.g. German, and set it as the administrator language (User Menu → Edit Account → Basic Settings → Backend Language, or Global Configuration).
  2. Go to System → Manage → Plugins and open "Editor - TinyMCE".
  3. Look at the "TinyMCE Panels" area, at the source panel below "The list of available menus and buttons".
  4. Check the menu row and hover a few toolbar buttons to see their tooltips.

Actual result BEFORE applying this Pull Request

The menu row is English: Edit Insert View Format Table Tools Help, the dropdowns show Formats and Paragraph, and the button tooltips are English as well.

Expected result AFTER applying this Pull Request

The menu row is translated: Bearbeiten Einfügen Ansicht Format Tabelle Werkzeuge Hilfe, the dropdowns show Formate, Absatz and Schriftgröße, and the tooltips are translated too.

Tested on a fresh 5.4.9-dev installation with the German language pack 5.4.8.1.

(A string like Font Family stays English, that string simply does not exist in the TinyMCE language pack. Unrelated to this change.)

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar tecpromotion tecpromotion - open - 9 Sep 2026
avatar tecpromotion tecpromotion - change - 9 Sep 2026
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Sep 2026
Category ⇒ Layout
avatar tecpromotion
tecpromotion - comment - 9 Sep 2026

Companion PR for 6.2-dev: #48435. There the same layout change is needed plus a second fix, because the new build system no longer produces the .min.js language files the builder field looks for.

avatar tecpromotion tecpromotion - change - 9 Sep 2026
Title
…
[AI] [5.4] Fix untranslated buttons in the TinyMCE builder
[5.4] [AI] Fix untranslated buttons in the TinyMCE builder
avatar tecpromotion tecpromotion - edited - 9 Sep 2026
avatar brianteeman brianteeman - test_item - 10 Sep 2026 - Tested successfully
avatar brianteeman
brianteeman - comment - 10 Sep 2026

I have tested this item ✅ successfully on 4ea2470


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48434.

avatar brianteeman
brianteeman - comment - 10 Sep 2026

I have tested this item ✅ successfully on 4ea2470


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48434.

avatar heelc29 heelc29 - test_item - 10 Sep 2026 - Tested successfully
avatar heelc29
heelc29 - comment - 10 Sep 2026

I have tested this item ✅ successfully on 4ea2470

image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48434.
avatar heelc29
heelc29 - comment - 10 Sep 2026

I have tested this item ✅ successfully on 4ea2470

image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48434.
avatar richard67 richard67 - change - 10 Sep 2026
The description was changed
Status Pending ⇒ Ready to Commit
Labels Added: bug PR-5.4-dev
avatar richard67
richard67 - comment - 10 Sep 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48434.

avatar richard67
richard67 - comment - 10 Sep 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48434.

avatar richard67 richard67 - edited - 10 Sep 2026
avatar muhme muhme - change - 11 Sep 2026
Labels Added: RTC
avatar muhme
muhme - comment - 11 Sep 2026

✅ Final test before merge with JBT

  • Additional installed languages de-CH, ca-ES and ja-JP
  • Before PR
    • Using Backend Language and tested TinyMCE plugin configuration
      • Independed from used backend language selection the buttons, dropdowns and tooltips are in German
  • Applied PR with Patch Tester
    • Using Backend Language and tested TinyMCE plugin configuration
      • Default or 'English (United Kingdom)' -> buttons, dropdown and tooltips are in English
      • 'Català (ca-Es)' -> buttons, dropdown and tooltips are in Catalan
        • Some single entries are not translated (e.g. 'Help' menu entry or 'background text color' tooltip)
      • '日本語 (Japan)' -> buttons and tooltips are in Japanese
        • Same single entries are not translated
      • 'Deutsch (Schweiz)' -> buttons, dropdown and tooltips are in German
        • 'Help' menu entry is translated as 'Hilfe' but 'background text color' tooltip untranslated
    • TinyMCE article editing is still showing the translated buttons, dropdowns and tooltips using default and all 4 different backend languages
avatar muhme muhme - change - 11 Sep 2026
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2026-09-11 04:26:19
Closed_By ⇒ muhme
avatar muhme muhme - close - 11 Sep 2026
avatar muhme muhme - merge - 11 Sep 2026
avatar muhme
muhme - comment - 11 Sep 2026

Thank you very much @tecpromotion for your contribution. Thanks to @brianteeman and @heelc29 for testing.

Add a Comment

Login with GitHub to post a comment