User tests: Successful: Unsuccessful:
I have commited changes to show the Maximum upload file size on installation screen and in media manager
Labels |
Added:
?
|
Rel_Number | ⇒ | 4355 | |
Relation Type | ⇒ | Related to |
Thanks for the proposed implementation!
Agree with nice suggestion of @coolbung - Another Suggestion: Can you please make it a link from the displayed size to a help-page (to be created on the php limits and instructions on how to increase them, e.g. to http://docs.joomla.org/Increasing_PHP_uload_limit with a title text for the link "How to increase that size ?") ?
No please do not do that. It is unique to every host and only hosts can
give the correct answer.
On 18 Oct 2014 18:19, "beat" notifications@github.com wrote:
Thanks for the proposed implementation!
Agree with nice suggestion of @coolbung https://github.com/coolbung -
Another Suggestion: Can you please make it a link from the displayed size
to a help-page (to be created on the php limits and instructions on how to
increase them, e.g. to http://docs.joomla.org/Increasing_PHP_uload_limit
with a title text for the link "How to increase that size ?") ?—
Reply to this email directly or view it on GitHub
#4837 (comment).
I'd suggest we refrain from the link to the docs since I feel that's
something that shouldn't be seen by the end users. Don't think we should
trade simplicity to add this information.
Someone who wants to really change the upload limit that can easily figure
out how to do that.
Maybe this wiki page should not tell users how to increase limit but just tell them why that ,how to find solution or where can ask for help? (Like a FAQ)
For Example:
bula bula
bula bula
Please contact your host provider
If you can't increase limit, upload it by FTP and use Install from Directory
instead...
Step1
Step2
Step3
Find help from Forum
I think this is helpful enough for most people who is not so familiar to host management.
Attention: JFilesystemHelper::fileUploadMaxSize was added to the 3.4-dev branch, you did your PR against the staging branch!
This feature can not be added to staging (at least at the moment)!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4837.
@brianteeman Giving helpful information/errors to users includes helping them solve errors/limits. Don't understand why you think it is against simplicity to provide solution with error/information: Read my comment again, it takes in account the consensus of the other thread to not add technical information, but to point to a general help-page which should probably start with: Contact your hoster if you have one to increase that limit... B.R.
The only tooltip I would personally accept is the same one that we have for php5.3
"Please contact your host"
If you look at the forums and see how many people are wasting their time following 20 different pieces of advice that dont work for them because thats disabled on their host.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4837.
The only tooltip I would personally accept is the same one that we have for
php5.3
"Please contact your host"
If you look at the forums and see how many people are wasting their time
following 20 different pieces of advice that dont work for them because
thats disabled on their host.
On 19 October 2014 00:18, beat notifications@github.com wrote:
@brianteeman https://github.com/brianteeman Giving helpful
information/errors to users includes helping them solve errors/limits.
Don't understand why you think it is against simplicity to provide solution
with error/information: Read my comment again, it takes in account the
consensus of the other thread to not add technical information, but to
point to a general help-page which should probably start with: Contact your
hoster if you have one to increase that limit... B.R.—
Reply to this email directly or view it on GitHub
#4837 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@brianteeman i'm ok with your proposal, any hint is far better than none !!!
A suggested improvement of it (can be another PR): Detect if we are not on localhost to display that, and in the localhost case point to a docs.joomla.org page, which also starts with Please contact your host if you are hosted.
For the extension manager "contact host" makes sense, but for media manager I'd prefer "contact admin", because anyone could be allowed to use the media manager. Even if a user (client) knows who "host" is - I'd rather not have them contact host - but me, the admin.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4837.
That's the exact reason why I feel we should not have that kind of text in
the first place in any of the upload fields. Someone who wants to increase
will know or be able to figure it out.
If we have a well written page on docs as Beat suggests ( in don't mind
writing that one) that's bound to come up in a search.
Best Regards,
Ashwin
I realise not everyone would be able to figure that out.. but I'm for
reducing all the clutter that we can.. make a simple and clean interface
with only the necessary bits.
This patch is working. I used and now i can see a limit of 60M maximum upload. But i think the design should be better.
I have tested this item unsuccessfully on ab673d2
Works great in the installation manager
Doesnt appear to do anything in the mdia manager (perhaps the code in media manager has changed since this PR)
Lets get this PR finalised and then if people want to have tooltips they can be discussed then in a seperate PR
Category | ⇒ | Administration |
@vaishalivk can you look at the issue with media manager please. Otherwise this will be closed in a few weeks s it cant be merged as it is
Status | Pending | ⇒ | Information Required |
Thank you for creating this. It’s been some time since you created this and there are now some merge conflicts that prevent a direct merge. The Media Manager is currently been rewritten, please consider to make a new PR against this repository.
Status | Information Required | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-08 14:33:38 |
Closed_By | ⇒ | Kubik-Rubik |
Labels |
Added:
?
|
To make this complete, can you also add a list of supported file types. You can say this -
Only jpg, png, gif files. Maximum size 2M.