User tests: Successful: Unsuccessful:
Pull Request resolves #48330
TagModel.php:
Replaced a hardcoded $this->setState('tag.state', 1) with a permission check that mirrors com_content. If a user has core.edit or core.edit.state permissions for com_tags, the query state filter is set to '0,1' so they can see unpublished items.
default_items.php:
Unpublished items were being given a <li class="list-group-item-danger"> modifier class without the required list-group-item base class. This caused unpublished items to lose all list-group styling and render as plain bullet points once they finally became visible.
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | com_tags Front End |
@brianteeman,
Now that I think about it, your concern is valid.
Someone with permission to manage the tags shouldn't automatically be able to read unpublished articles or other content they don't have permission to edit.
But, implementing component-specific permission checks on every tagged piece of content here can get quite complicated.
I'll draft this PR for now and give it a try
But, implementing component-specific permission checks on every tagged piece of content here can get quite complicated.
probably why it was never done before
But this is related to the display of content so shouldnt the permission check be to see if the user has the permission to see the content? (or contact or anything else that can be tagged)