Pending

User tests: Successful: Unsuccessful:

avatar hiteshm0
hiteshm0
3 Sep 2026

Pull Request resolves #48330

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

TagModel.php:
Replaced a hardcoded $this->setState('tag.state', 1) with a permission check that mirrors com_content. If a user has core.edit or core.edit.state permissions for com_tags, the query state filter is set to '0,1' so they can see unpublished items.

default_items.php:
Unpublished items were being given a <li class="list-group-item-danger"> modifier class without the required list-group-item base class. This caused unpublished items to lose all list-group styling and render as plain bullet points once they finally became visible.

Testing Instructions

  1. Create a new Article, assign a tag to it, and set its status to Unpublished.
  2. Create a frontend Menu Item of type Tags -> Tagged Items (Tag list) and point it to your tag.
  3. Open the frontend site in a private window/guest session and navigate to the tag list. Ensure the unpublished article does not appear.
  4. Log into the frontend as a Super User or Editor (a user with edit or edit state permissions).
  5. Navigate to the tag list page again.
  6. Verify that the unpublished article now appears in the list and is styled correctly with a red border.

Actual result BEFORE applying this Pull Request

  1. Unpublished items are completely missing from the frontend tag list for all users, regardless of permissions.

Expected result AFTER applying this Pull Request

  1. Regular users/guests still do not see unpublished items.
  2. Authorized users (Editors/Admins) can see unpublished items in the tag list.
  3. The unpublished items render properly inside the Bootstrap list group ( with a red border).

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar hiteshm0 hiteshm0 - open - 3 Sep 2026
avatar hiteshm0 hiteshm0 - change - 3 Sep 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Sep 2026
Category com_tags Front End
avatar hiteshm0 hiteshm0 - change - 3 Sep 2026
The description was changed
avatar hiteshm0 hiteshm0 - edited - 3 Sep 2026
avatar brianteeman
brianteeman - comment - 3 Sep 2026

If a user has core.edit or core.edit.state permissions for com_tags

But this is related to the display of content so shouldnt the permission check be to see if the user has the permission to see the content? (or contact or anything else that can be tagged)

avatar hiteshm0
hiteshm0 - comment - 3 Sep 2026

@brianteeman,
Now that I think about it, your concern is valid.
Someone with permission to manage the tags shouldn't automatically be able to read unpublished articles or other content they don't have permission to edit.

But, implementing component-specific permission checks on every tagged piece of content here can get quite complicated.
I'll draft this PR for now and give it a try

avatar brianteeman
brianteeman - comment - 3 Sep 2026

But, implementing component-specific permission checks on every tagged piece of content here can get quite complicated.

probably why it was never done before

avatar CSGoat0
CSGoat0 - comment - 6 Sep 2026

To allow user with permissions to see other states at the frontend, it requires new populated values and a plan to adapt Joomla that change.
I can only agree to the style changes, for more details check this comment.

avatar hiteshm0
hiteshm0 - comment - 6 Sep 2026

@CSGoat0 I'll make a seperate PR for the style changes, and it might be possible to fix this issue without significant architectural changes, lets see.

Add a Comment

Login with GitHub to post a comment