User tests: Successful: Unsuccessful:
Pull Request resolves #48364.
Set Joomla's standard 0644 file permissions after the local media adapter writes uploaded or updated files. This prevents restrictive server umasks from leaving Media Manager uploads with permissions such as 0600, which makes uploaded files inaccessible via URL and breaks Media Manager previews.
Added a regression unit test that simulates a restrictive umask during a Media Manager file upload and confirms the final file mode is 0644.
Automated checks run:
Media Manager uploads can inherit restrictive file permissions from the server/PHP umask, for example 0600. The upload succeeds, but the file cannot be accessed through the web server and previews do not work.
Media Manager uploads are explicitly set to Joomla's default file permissions of 0644 after being written. Uploaded files are accessible via URL and previews work in Media Manager.
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Front End Plugins Unit Tests |
@brianteeman - my apologies! My first commit for joomla and completely missed the guidance, hope my revised comment is more informative :)
If the server has a restrictive umask then wouldnt it be the expected behaviour for that to be honored?
As brian guesses this would break server side security measurements, I'm closing this and the issue since it's a server configuration problem and not a Joomla problem.
Anyway thanks for your first contribution.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-09-03 18:20:29 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
Unit/System Tests
PR-6.1-dev
|
||
I didn't guess I was being tactful
There was a reason you were given a template to complete when you submitted the PR. It was not for fun. Please update your PR with the relevant information - you can find the template here https://github.com/joomla/joomla-cms/blob/5.4-dev/.github/PULL_REQUEST_TEMPLATE.md