[#48338] - [6.3] [joomla/database] use createQuery
- Pending
- Medium
- Build: 6.1-dev
- # 48338
- Diff
- heelc29:6.1/database/createquery
User tests: Successful: Unsuccessful:
Pull Request resolves # .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Apply changes from #45056 to new files (upmerged form 5.4 or merged prs to 6.1)
Replaced all fuction calls getQuery(true) with createQuery() but only in database related context.
Note: There is also a getQuery(true) functionality in Joomla\CMS\Uri\Uri that must remain untouched.
Testing Instructions
code review or check logs files (option log deprecated in global configuration)
Actual result BEFORE applying this Pull Request
Since joomla/database 2.2.0: The parameter $new is deprecated and will be removed in 4.0, use Joomla\Database\DatabaseDriver::createQuery() instead.
Expected result AFTER applying this Pull Request
No warnings for getQuery(true)
Link to documentations
Please select:
- No documentation changes for guide.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus com_tags com_workflow Libraries |
| Title |
|
||||||
| Category | Administration com_menus com_tags com_workflow Libraries | ⇒ | Administration com_menus com_tags com_templates com_workflow Installation Language & Strings |
rebased to 6.3, it's not a bugfix.
My thought process:
- using a deprecated function = bug
- usage was introduced in 6.1-dev
- PR against 6.1-dev
I’m fine with the decision.
![avatar github-actions[bot]](/images/avatars/github-actions[bot].png)
This pull request has conflicts, please resolve those before we can evaluate the pull request.
rebased to 6.3, it's not a bugfix.