Unit/System Tests PR-6.1-dev Pending

User tests: Successful: Unsuccessful:

avatar atirna
atirna
26 Aug 2026

Pull Request resolves #48313.

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Preserve the original Registry instance for the article model's params state while building month-filter options.

Testing Instructions

  1. In Content Options, set List Layouts > Filter Field to Month.
  2. Open a category blog or list layout that uses the setting.
  3. Confirm the page renders and the month filter is available.

Actual result BEFORE applying this Pull Request

The state-copy loop turns the nested params Registry into an array. The article model then fails when it calls get() on that state.

Expected result AFTER applying this Pull Request

The article model retains the original params Registry, so category listings render with the month filter enabled.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Verification

  • ./libraries/vendor/bin/phpunit --configuration phpunit.xml.dist tests/Unit/Libraries/Cms/Html/ContentTest.php
  • ./libraries/vendor/bin/php-cs-fixer fix -vvv --dry-run --diff
  • ./libraries/vendor/bin/phpcs --extensions=php -p --standard=ruleset.xml .
avatar atirna atirna - open - 26 Aug 2026
avatar atirna atirna - change - 26 Aug 2026
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2026
Category ⇒ Libraries Unit Tests
avatar tecpromotion tecpromotion - change - 26 Aug 2026
Title
…
[AI] [6.1] Preserve Registry params for month filtering
[6.1] [AI] Preserve Registry params for month filtering
avatar tecpromotion tecpromotion - edited - 26 Aug 2026
avatar atirna atirna - change - 28 Aug 2026
Labels Added: Unit/System Tests PR-6.1-dev
avatar alikon alikon - test_item - 28 Aug 2026 - Tested successfully
avatar alikon
alikon - comment - 28 Aug 2026

I have tested this item ✅ successfully on d517602


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48322.

avatar alikon
alikon - comment - 28 Aug 2026

I have tested this item ✅ successfully on d517602


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48322.

avatar brianteeman
brianteeman - comment - 28 Aug 2026

Almost but not quite complete

You dont get an error message any more but after you have selected a month and then gone to page 2 the month is no longer selected in the filter

thorium_KbqlQNaI3v.mp4
avatar alikon alikon - alter_testresult - 28 Aug 2026 - alikon: Not tested
avatar alikon alikon - alter_testresult - 28 Aug 2026 - alikon: Not tested
avatar alikon
alikon - comment - 28 Aug 2026

I have not tested this item

avatar heelc29
heelc29 - comment - 28 Aug 2026

You dont get an error message any more but after you have selected a month and then gone to page 2 the month is no longer selected in the filter

@brianteeman The filter field is currently not working due #47774 - this also affects Joomla 5.4.
https://github.com/joomla/joomla-cms/pull/47774/changes#diff-47a06476bc1b08e7a8a5073d867d3aec09113bca7d2be7f05c66b1799105a4c9
image

avatar heelc29
heelc29 - comment - 28 Aug 2026

It looks as the AI has taken the wrong approach here.
Instead of fixing the error that broke the function (it had previously worked in J5.4), it simply do a band aid.

For further information check #48339

avatar atirna
atirna - comment - 28 Aug 2026

closing this, #48339 fixes the registry regression that actually causes it so this line isnt the right place for it.

thx for testing @alikon @brianteeman, and @heelc29 for the pointer to the upstream fix

avatar atirna
atirna - comment - 28 Aug 2026

closing this, #48339 fixes the registry regression that actually causes it so this line isnt the right place for it.

avatar atirna
atirna - comment - 28 Aug 2026

closing this, #48339 fixes the registry regression that actually causes it

avatar atirna atirna - change - 28 Aug 2026
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2026-08-28 17:15:06
Closed_By ⇒ atirna
avatar atirna atirna - close - 28 Aug 2026

Add a Comment

Login with GitHub to post a comment