[#48306] - [6.2] Mail Templates: Fix lookup in extension table
- Pending
- Medium
- Build: 5.4-dev
- # 48306
- Diff
- Hackwar:5.4-mailtemplates
User tests: Successful: Unsuccessful:
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
In the list view of the mail templates (under System -> Templates -> Mail Templates) the list of available templates is joined against the list of active extensions we have in the system. This means that inactive extensions (plugins, components, etc.) automatically remove the mail templates from the list. Clever thing, good design, but the problem is, that we are comparing #__mail_templates.extension column against the #__extension.name column, which can contain basically anything. That column could for example contain a translatable string to translate the name of the extension into different languages and that could be different to the extensions element name like com_users. Or it is a single language site anyway and the developer simply used the translated name in that column directly. That is perfectly fine, but in this case this results in the mail templates not showing up.
The correct column to check against would be #__extensions.element, the internal key of the extension and the value that the mail templates use in the extension column.
Testing Instructions
- Go to
#__extensionsand edit thenamecolumn of thecom_userscomponent. Change it toUser Management. - Go to the Mail Templates component.
Actual result BEFORE applying this Pull Request
No mail templates of the user component show up, even though the user component is still accessible and working fine otherwise.
Expected result AFTER applying this Pull Request
The mail templates show up.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
I have tested this item ✅ successfully on aca5793
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48306.
I have tested this item ✅ successfully on aca5793
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48306.
I have tested this item ✅ successfully on aca5793
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48306.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48306.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48306.
I had a look how it is built with DPCalendar. For the component, the name is the same as element, both com_dpcalendar. But for the task plugin, the name attribute in the extension table is plg_task_dpcalendar while the element column has only dpcalendar. So this would break mail templates for the plugin.
I have tested this item 🔴 unsuccessfully on aca5793
I have to withdraw my successfull test. Allons and Richard are absolutely right. I tested the module and the component, but a plugin simply cannot work like that by design. Not even the core plugins would do.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48306.
I have tested this item 🔴 unsuccessfully on aca5793
I have to withdraw my successfull test. Allons and Richard are absolutely right. I tested the module and the component, but a plugin simply cannot work like that by design. Not even the core plugins would do.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48306.
I have tested this item 🔴 unsuccessfully on aca5793
I have to withdraw my successfull test. Allons and Richard are absolutely right. I tested with module and the component, but a plugin simply cannot work like that by design. Not even the core plugins would do.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48306.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending due to unsuccessful human test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48306.
Back to pending due to unsuccessful human test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48306.
This pull request has been automatically rebased to 6.2-dev. Joomla! 5.4 is now in security only mode.
![avatar github-actions[bot]](/images/avatars/github-actions%5Bbot%5D.png)
This pull request has conflicts, please resolve those before we can evaluate the pull request.
muhme
- | Title |
|
||||||
| Labels |
Added:
Conflicting Files
Updates Requested
bug
PR-6.2-dev
Removed: PR-5.4-dev |
||
Hi @Hackwar, I am not 100% that I was able to test this successfully.
BEFORE the PR fix:
When I go to the Mail Templates component: I get 29 items.
AFTER the PR fix:
When I edited #__extensions and edited the name column of the com_users component and changed it to User Management, when I went to Mail Templates component, I got this:
24 items with missing translated strings
then I put #__extensions name column of the com_users component back to com_users just to see what would happen and I got this:
24 items with filled in translated strings.
Somehow that doesn't 'seem' to be what you are after, or is it?
This is a test for the issue tracker
Another test for the issue tracker
Another test for the issue tracker
Another test for the issue tracker
And another test.
Last test.
I have tested this item ✅ successfully on aca5793
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48306.