There was a reason you were given a template to complete when you submitted the PR. As it is right now it is completely useless.

Please update your post using the pull request template which you can find here https://github.com/joomla/joomla-cms/blob/5.4-dev/.github/PULL_REQUEST_TEMPLATE.md

Otherwise it will have to be closed.

There was a reason you were given a template to complete when you submitted the PR. As it is right now it is completely useless.

Please update your post using the pull request template which you can find here https://github.com/joomla/joomla-cms/blob/5.4-dev/.github/PULL_REQUEST_TEMPLATE.md

Otherwise it will have to be closed.

Correct. The AI policy has to be confirmed, issue #48255 should be referred in the description, and real testing instructions for end users have to be provided.

P.S.: Our contribution guidelines require that PR authors have tested their PR themselves before submitting. Telling to check a git diff as testing instruction clearly show that the author obviously has not done that, and it is even questionable if he has ever used Joomla.

@richard67 i was trying to be polite in my reply which is why i didnt comment on diff being a good way to test

@richard67 i was trying to be polite in my reply which is why i didnt comment on diff being a good way to test

Well, maybe I was a bit too harsh. Sorry for that.

This is what your pull request should have looked like, with clear instructions how to replicate the reported problem and before and after results #48303

@jiteshkhatri11 Thank you for your contribution. The fix works, but this is an improvement rather than a bug fix and should therefore target the 6.3-dev branch.

Please also consider the comments above: use the PR template, link the related issue and provide testing instructions.

For these reasons, we will close this PR. You're welcome to open a new PR against 6.3-dev with these points addressed.