[#4828] - Code Style - "default_address"
- Closed
- 15 Apr 2016
- Medium
- Build: staging
- # 4828
- Diff
- LLNet:#CodeStyle_4
- Success continuous-integration/travis-ci The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
- "br" outside of php print
- removed not logical if
- add tabs (\t)
- remove space in ends of html tag
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Code style |
| Labels |
Added:
?
|
||
I have tested this item 
successfully on 7d5bcae
Code cleaning according to given issue.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4828.
Hello @LLNet
Thank you for your contribution.
The last comment here was on [date]. So the question is, Is this issue/pull request still valid?
if so please provide clear test instructions to be able to test / reproduce this issue.
If no reply is received within 4 weeks we will close this issue.
Thanks for understanding!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4828.
This PR is still valid.
It addresses several things although they are mainly just code style (moving the br from the php statement)
It also ensures valid markup by preventing having a definition list that doesnt define its terms
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4828.
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4828.
I have tested this item successfully on 7d5bcae
The code looks a lot cleaner.
I see no changes in the front-end.
Tested with the testing sample data in /index.php/single-contact
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4828.
| Status | Pending | ⇒ | Ready to Commit |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-15 19:27:42 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
| Milestone | |||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone | |||
Can you add some testing information to reproduce or see how this is showing up.
At this moment it is a bit hard to test this issue.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4828.