Conflicting Files PR-6.2-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
19 Aug 2026

Pull Request resolves #48273 .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

this is a DRAFT pr for review not merging - I'm sure it can be improved

the aim is to give a meaningful error message

Testing Instructions

delete $secret from confiuration.php
try to create a new article or edit an existing article

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 19 Aug 2026
avatar brianteeman brianteeman - change - 19 Aug 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2026
Category Administration com_content Front End
avatar brianteeman brianteeman - change - 19 Aug 2026
The description was changed
avatar brianteeman brianteeman - edited - 19 Aug 2026
avatar HLeithner
HLeithner - comment - 19 Aug 2026

thanks for the pr, but the real problem is that the feature pr #48030 needs to be reverted. It uses the site secret, which is not secret, even if it names would says it... the original PR would produce a security issue.

Your PR is also on the wrong position, the website should not "boot" if no secret is given because it's used for other things which would need it. Having this check in the application would be a better place. But the main issue is that Joomla as no real secret and it's also not so easy to introduce a "real_secret" parameter.

avatar brianteeman
brianteeman - comment - 19 Aug 2026

I did report the missing secret as used when generating the API key to JSST but had no response

avatar brianteeman
brianteeman - comment - 19 Aug 2026

I did report the missing $secret as used when generating the API key to JSST but had no response and created a PR which at least logged an error #48198 for that use case

avatar github-actions[bot]
github-actions[bot] - comment - 31 Aug 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

avatar brianteeman brianteeman - change - 31 Aug 2026
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2026-08-31 18:44:26
Closed_By brianteeman
Labels Added: Conflicting Files PR-6.2-dev
avatar brianteeman brianteeman - close - 31 Aug 2026

Add a Comment

Login with GitHub to post a comment