User tests: Successful: Unsuccessful:
Pull Request resolves #48273 .
this is a DRAFT pr for review not merging - I'm sure it can be improved
the aim is to give a meaningful error message
delete $secret from confiuration.php
try to create a new article or edit an existing article
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_content Front End |
I did report the missing secret as used when generating the API key to JSST but had no response
This pull request has conflicts, please resolve those before we can evaluate the pull request.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-08-31 18:44:26 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
Conflicting Files
PR-6.2-dev
|
||
thanks for the pr, but the real problem is that the feature pr #48030 needs to be reverted. It uses the site secret, which is not secret, even if it names would says it... the original PR would produce a security issue.
Your PR is also on the wrong position, the website should not "boot" if no secret is given because it's used for other things which would need it. Having this check in the application would be a better place. But the main issue is that Joomla as no real secret and it's also not so easy to introduce a "real_secret" parameter.