RTC PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
18 Aug 2026

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

alpha sort the two lists of extensions/filetypes
it makes it easier for a human to see if anything is missing etc

Testing Instructions

code review

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 18 Aug 2026
avatar brianteeman brianteeman - change - 18 Aug 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Aug 2026
Category Administration com_templates Libraries
avatar richard67 richard67 - change - 18 Aug 2026
Labels Added: PR-5.4-dev
avatar QuyTon QuyTon - test_item - 19 Aug 2026 - Tested successfully
avatar QuyTon
QuyTon - comment - 19 Aug 2026

I have tested this item ✅ successfully on 6c08c6b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48270.

avatar QuyTon
QuyTon - comment - 19 Aug 2026

I have tested this item ✅ successfully on 6c08c6b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48270.

avatar richard67
richard67 - comment - 19 Aug 2026

@brianteeman The same change as here in the libraries/src/Filter/InputFilter.php for the FORBIDDEN_FILE_EXTENSIONS should also be made in the filesystem framework here: https://github.com/joomla-framework/filesystem/blob/3.x-dev/src/File.php#L27-L30

In addition, if we add here in the CMS 'php9' to the FORBIDDEN_FILE_EXTENSIONS and alpha sort in the framework, both lists would be equal, because as far as I can see the only difference between these 2 lists is that in the framework 'php9' was added.

Could you do that, add 'php9' to the FORBIDDEN_FILE_EXTENSIONS here and make a PR in the filesystem framework for alpha sorting?

avatar brianteeman
brianteeman - comment - 19 Aug 2026

is php9 even a valid extension - it might be a rare extension like php8 but only when php9 is release which doesnt have a date yet

avatar richard67
richard67 - comment - 19 Aug 2026

is php9 even a valid extension - it might be a rare extension like php8 but only when php9 is release which doesnt have a date yet

@brianteeman Well, we would be prepared for the future, I think that was why it was added to the framework, and both lists would be equal if we add it here, too.

Was just an idea, I would not insist on it.

avatar brianteeman
brianteeman - comment - 19 Aug 2026

to keep you happy :) I updated it here to match the PR I just created in the framework

avatar richard67 richard67 - alter_testresult - 19 Aug 2026 - QuyTon: Tested successfully
avatar richard67 richard67 - test_item - 19 Aug 2026 - Tested successfully
avatar richard67
richard67 - comment - 19 Aug 2026

I have tested this item ✅ successfully on bece569


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48270.

avatar richard67
richard67 - comment - 19 Aug 2026

I have tested this item ✅ successfully on bece569


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48270.

avatar richard67 richard67 - change - 19 Aug 2026
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 19 Aug 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48270.

avatar richard67
richard67 - comment - 19 Aug 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48270.

avatar muhme muhme - change - 25 Aug 2026
Labels Added: RTC
avatar muhme muhme - close - 25 Aug 2026
avatar muhme muhme - merge - 25 Aug 2026
avatar muhme muhme - change - 25 Aug 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-08-25 17:36:27
Closed_By muhme
avatar muhme
muhme - comment - 25 Aug 2026

Thank you very much @brianteeman for your contribution. Thank you @QuyTon for testing. Thank you @richard67 for support and testing.

avatar brianteeman
brianteeman - comment - 25 Aug 2026

thanks

Add a Comment

Login with GitHub to post a comment