User tests: Successful: Unsuccessful:
Pull Request resolves # .
alpha sort the two lists of extensions/filetypes
it makes it easier for a human to see if anything is missing etc
code review
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_templates Libraries |
| Labels |
Added:
PR-5.4-dev
|
||
I have tested this item ✅ successfully on 6c08c6b
@brianteeman The same change as here in the libraries/src/Filter/InputFilter.php for the FORBIDDEN_FILE_EXTENSIONS should also be made in the filesystem framework here: https://github.com/joomla-framework/filesystem/blob/3.x-dev/src/File.php#L27-L30
In addition, if we add here in the CMS 'php9' to the FORBIDDEN_FILE_EXTENSIONS and alpha sort in the framework, both lists would be equal, because as far as I can see the only difference between these 2 lists is that in the framework 'php9' was added.
Could you do that, add 'php9' to the FORBIDDEN_FILE_EXTENSIONS here and make a PR in the filesystem framework for alpha sorting?
is php9 even a valid extension - it might be a rare extension like php8 but only when php9 is release which doesnt have a date yet
is php9 even a valid extension - it might be a rare extension like php8 but only when php9 is release which doesnt have a date yet
@brianteeman Well, we would be prepared for the future, I think that was why it was added to the framework, and both lists would be equal if we add it here, too.
Was just an idea, I would not insist on it.
to keep you happy :) I updated it here to match the PR I just created in the framework
I have tested this item ✅ successfully on bece569
I have tested this item ✅ successfully on bece569
| Status | Pending | ⇒ | Ready to Commit |
RTC
RTC
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-08-25 17:36:27 |
| Closed_By | ⇒ | muhme |
Thank you very much @brianteeman for your contribution. Thank you @QuyTon for testing. Thank you @richard67 for support and testing.
thanks
I have tested this item ✅ successfully on 6c08c6b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48270.