[#48262] - [6.2] filter = integer
- Pending
- Medium
- Build: 6.2-dev
- # 48262
- Diff
- brianteeman:filter_int
User tests: Successful: Unsuccessful:
Pull Request resolves # .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
when you add filter="int" it is run through cleanInt libraries\vendor\joomla\filter\src\InputFilter.php
when you add filter="integer" then its cleanInteger which is just an alias for cleanInt
We have 28 instances of int and 508 of integer
I find this inconsistency confusing. I understand that both versions work but I wasted quite some time establishing that for myself
This PR standardises on using integer
Testing Instructions
code review and passing the tests should be enough as this change is just for consistency
Actual result BEFORE applying this Pull Request
We have 28 instances of int
Expected result AFTER applying this Pull Request
We have instances of int
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_menus Front End Plugins |
I have tested this item ✅ successfully on d4a1852
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48262.
We have 28 instances of int and 508 of integer
The diff shows 29 instances changed, not 28. maybe you missed one ;-)
Expected result AFTER applying this Pull Request
We have instances of int
you mean "0" instances. right ?
Not a big thing but wouldn't it make more sense if we use filter="int" instead of filter="integer" for the following reasons:
- cleanInteger is an alias of cleanInt, so filter="int" would be faster
- PHP core also prefer int over integer (int is valid type, is_integer is deprecated in PHP 8.6)
@joomdonation that was my thought to - especially as integer is an alias to int - but I asked for advice from @HLeithner and he suggested to do it this way
I have tested this item ✅ successfully on d4a1852
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48262.