[#48251] - [6.2] Redirect back to Updated Files tab after close/save
- Pending
- Medium
- Build: 5.4-dev
- # 48251
- Diff
- alwaysalearner1234:fix-48032-redirect-updated-files
User tests: Successful: Unsuccessful:
Pull Request resolves #48032.
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
When a user opens an override file from the Updated Files tab and then closes or saves it, the redirect was incorrectly sending them to the Editor tab instead of back to the Updated Files tab.
3 files changed:
default_updated_files.php— Added&return=updated_filesto each filename linkdefault.php— Added a hidden<input name="return">to the file-edit form so the parameter survives POST submission (toolbar Close/Save buttons)TemplateController.php— Inclose()and the default case ofsave(), detectsreturn=updated_filesand appends#filesto the redirect URL so thejoomla-tabcomponent activates the Updated Files tab on load
The apply task is intentionally unaffected — it keeps the user on the editor screen.
Testing Instructions
- Go to Extensions → Templates → [any template]
- Click the Updated Files tab (requires the Installer – Override plugin to be enabled and at least one outdated override to be present)
- Click a filename link — notice the URL now contains
&return=updated_files - Click Close File — you should be redirected back to the Updated Files tab ✅
- Repeat steps 3–4 but click Save instead — same result ✅
- Open a file from the regular Editor file tree — closing it should still redirect to the default Editor view (no regression) ✅
Actual result BEFORE applying this Pull Request
After closing or saving an override file opened from the Updated Files tab, the user is redirected to the Editor tab, losing their place in the override review workflow.
Expected result AFTER applying this Pull Request
After closing or saving the file, the user is redirected back to the Updated Files tab, allowing them to continue marking overrides as checked.
Link to documentations
- No documentation changes for guide.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
tecpromotion
- | Title |
|
||||||
| Title |
|
||||||
I have tested this item ✅ successfully on 6746feb
Works as described, thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48251.
I have tested this item ✅ successfully on 6746feb
Thank you! So simple but makes working through the overrides so much more intuitive. Love it! :green-heart:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48251.
I have tested this item ✅ successfully on 6746feb
Thank you! So simple but makes working through the overrides so much more intuitive. Love it! :green-heart:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48251.
I have tested this item ✅ successfully on 6746feb
Thank you! So simple but makes working through the overrides so much more intuitive. Love it! 💚
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48251.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PBF
PR-5.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48251.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48251.
| Labels |
Added:
RTC
Removed: PBF |
||
I have tested this item 🔴 unsuccessfully on 8056dcd
First try to final test before merge with JBT, MariaDB, PHP 8.5
- Installed 5.4.6 and created overrides where we have changes in 5.4.8
- com_content/archive
- com_contact/category
- layouts/joomla/system
- layouts/joomla/form
- Updated to 5.4.8
- 8 changes in override files are shown, seen the issue: close the overwrite changes view returns to Editor, not to the list
- Applied PR by update with file upload
Joomla_5.4.9-dev+pr.48251-Development-Update_Package.zip- 8 changes are still shown
- View one change and in the template-file-changes view:
- ✅ 'Close' returns to the list
- ✅ 'Save & Close' returns to the list
- ❌ First 'Save' and second 'Close' returns to Editor
- ❌ 'Delete' returns to Editor
- ✅ 'Rename File' returns to the template-file-changes view
- ❌ First 'Rename File' and second 'Close' returns to Editor
- ✅ No unusual Joomla or PHP log entries were found on both instances
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48251.
I have tested this item 🔴 unsuccessfully on 8056dcd
First try to final test before merge with JBT, MariaDB, PHP 8.5
- Installed 5.4.6 and created overrides where we have changes in 5.4.8
- com_content/archive
- com_contact/category
- layouts/joomla/system
- layouts/joomla/form
- Updated to 5.4.8
- 8 changes in override files are shown, seen the issue: close the overwrite changes view returns to Editor, not to the list
- Applied PR by update with file upload
Joomla_5.4.9-dev+pr.48251-Development-Update_Package.zip- 8 changes are still shown
- View one change and in the template-file-changes view:
- ✅ 'Close' returns to the list
- ✅ 'Save & Close' returns to the list
- ❌ First 'Save' and second 'Close' returns to Editor
- ❌ 'Delete' returns to Editor
- ✅ 'Rename File' returns to the template-file-changes view
- ❌ First 'Rename File' and second 'Close' returns to Editor
- ✅ No unusual Joomla or PHP log entries were found on both instances
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48251.
I have tested this item 🔴 unsuccessfully on 8056dcd
First try to final test before merge with JBT, MariaDB, PHP 8.5
- Installed 5.4.6 and created overrides where we have changes in 5.4.8
- com_content/archive
- com_contact/category
- layouts/joomla/system
- layouts/joomla/form
- Updated to 5.4.8
- 8 changes in override files are shown, seen the issue: close the overwrite changes view returns to Editor, not to the list
- Applied PR by update with file upload
Joomla_5.4.9-dev+pr.48251-Development-Update_Package.zip- 8 changes are still shown
- View one change and in the template-file-changes view:
- ✅ 'Close' returns to the list
- ✅ 'Save & Close' returns to the list
- ❌ First 'Save' and second 'Close' returns to Editor
- ❌ 'Delete' returns to Editor
- ✅ 'Rename File' returns to the template-file-changes view
- ❌ First 'Rename File' and second 'Close' returns to Editor
- ✅ No unusual Joomla or PHP log entries were found
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48251.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending due failed test
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48251.
Back to pending due failed test
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48251.
This pull request has been automatically rebased to 6.2-dev. Joomla! 5.4 is now in security only mode.
| Title |
|
||||||
Delete, Rename and subsequent Save/Close actions need to be covered too. Otherwise we're just fixing the happy path and leaving users to discover the remaining holes for themselves.
I have tested this item ✅ successfully on 6746feb
Works as described, thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48251.