looks like OK here.

After clicking on the Help button on the Extension Manager | Manage page I just wanted to see what the intention of the button was and it appears it was originally written expecting someone to select an item from the list:
"Refresh cache. Refresh the information displayed for the selected extension(s)."

The problem I see with the current patch as-is, is that it only really resolves the UI portion of the problem (the popup dialog you mentioned) but it doesn't solve the changes that would be required within the InstallerModelManage class refresh() method (right now, if you just apply the patch and don't select any items and just click on the Refresh Cache button it'll hit that refresh() method and not actually do any work since it's expecting an array with the IDs of the extensions you want refreshed, but it doesn't refresh everything by default if an empty list is passed in).

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4825.

After lookin at refresh function in manage.php , i agree with orware.

i don't have time to test right now, but this should make an array with all extension's id :

$bdd = JFactory::getDbo();
$query = $db->getQuery(true);
$query->select('extension_id')->from('#__extensions');
$bdd->setQuery($query);
$eid = $db->loadColumn();

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4825.

When I tested, I modified some params in the _extensions table for some extensions and they were updated OK after this PR.

Infograf768, you mean the refresh function worked ?
can you give the param that you changed in the table, i ll try
thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4825.

Hi

Please don't merge this PR and don't make any changes here. It is working as expected currently. I didn't know what is "Refresh Cache" and how it works until I looked at the code. Lets me try to explain:

This feature was developed to allow you to update the Manifest file of one extension (the xml file) update the information author, author email, created date... (see the manifest_cache field in #__extensions table if you want to see what fields can be changed). After editing and updating the XML file of the extension you want, you can go to this page, select the extension you want to "Refresh Cache", fresh the button. The changes you made in the xml file is now updated to the database and displayed in Extension Manager page. Hope my explanation is clear enough.

So as I can see, the feature is working as expected currently and there is no need to change it :

1. As @orware pointed out, this PR just solved the UI problem but it doesn't solve the actual problem.

2. We can easy write code to allow "Refresh Cache" of all available extensions, however, it is not necessary. You would not modify xml files of all of your extensions and then "Refresh Cache". It seems this feature is designed for "developers", not for end-users. Also, in my local Joomla installation (use for extensions development - just small site), there are about 500 extensions (components/modules/plugins/templates...), so "refresh cache" of all of these extensions would cause timeout issue (for refresh cache of each extension, the sytem will need to read/parse xml files, the store the information into database.....)

Regards,

Tuan

@joomdonation
You are right

Thanks @infograf768. I think this PR can be closed.