[#48245] - [6.1] revert invalid path check change
- Fixed in Code Base
- 15 Aug 2026
- Medium
- Build: 6.1-dev
- # 48245
- Diff
- SniperSister:6.1-template-template-name
User tests: Successful: Unsuccessful:
Summary of Changes
While fixing #48171 a Path::clean was converted to Path::check that should have not been converted, causing error messages when uploading files in the template manager.
Testing Instructions
- Try upload a file in the template manager
Actual result BEFORE applying this Pull Request
- error message about "Snooping out of bounds", file being uploaded anyways
Expected result AFTER applying this Pull Request
- error message gone
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
I have tested this item ✅ successfully on 122e858
When I have PHP Error Reporting set to Maximum in global configuration, the file upload works, but I get:
Warning: Attempt to read property "filename" on null in /home/richard/lamp/public_html/joomla-cms-5.4-dev/administrator/components/com_templates/tmpl/template/default.php on line 66
This does of course not happen without this PR as that will run into the exception from Path:check before that happens.
But this means the error is not really caused by this PR.
That's why I submit a successful test.
But if that can be fixed with this PR, too, I would be happy to test again.
Ping @SniperSister .
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48245.
I have tested this item ✅ successfully on 122e858
* Tested with JBT
- Seen error before PR
- Applied PR with
gh pr checkout 48245- File upload in template manager is working again
⚠️ PHP log contains warning[15-Aug-2026 12:57:59 UTC] PHP Warning: Attempt to read property "filename" on null in /var/www/html/administrator/components/com_templates/tmpl/template/default.php on line 71
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48245.
I have tested this item ✅ successfully on 122e858
* Tested with JBT
- Seen error before PR
- Applied PR with
gh pr checkout 48245- File upload in template manager is working again
⚠️ PHP log contains warning[15-Aug-2026 12:57:59 UTC] PHP Warning: Attempt to read property "filename" on null in /var/www/html/administrator/components/com_templates/tmpl/template/default.php on line 71
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48245.
HLeithner
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-08-15 13:31:40 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
PR-6.1-dev
|
||
I've just verified that the PHP warning mentioned in @muhme 's and my test results is an old issue which exists also on a clean 6.1.2 installation, and the later PR #48171 has just masked it with the wrong "snooping out of bounds", which is fixed by this PR here.
So this PR here is ok, and the PHP warning can (and of course should) be fixed later.
I have tested this item ✅ successfully on 122e858
When I have PHP Error Reporting set to Maximum in global configuration, the file upload works, but I get:
This does of course not happen without this PR as that will run into the exception from
Path:checkbefore that happens.But this means the error is not really caused by this PR.
That's why I submit a successful test.
But if that can be fixed with this PR, too, I would be happy to test again.
Ping @SniperSister .
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48245.