RTC Unit/System Tests bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Otto-Deviant1904
Otto-Deviant1904
13 Aug 2026

Pull Request resolves #48033.

Replacement for #48083 (could not reopen after I closed it).

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

The JobPosting plugin currently writes the form values Telecommute, Onsite and Hybrid straight into jobLocationType. Google only accepts TELECOMMUTE there, so Rich Results Test flags the markup.

This maps the values when the JSON-LD is compiled:

  • Telecommute / Hybrid → TELECOMMUTE (Hybrid still keeps the physical jobLocation)
  • Onsite → omit jobLocationType and keep jobLocation

Form values and stored data are unchanged.

Testing Instructions

  1. Enable the "System - Schema.org" and "Schema.org - JobPosting" plugins, and set Schema.org as active for articles.
  2. Create an article, open its Schema tab, select the JobPosting type, and set the job location field to Onsite (repeat later with Hybrid and Telecommute). Save.
  3. View the article on the frontend and inspect the application/ld+json block in the page source, or run the URL through Google's Rich Results Test.

Actual result BEFORE applying this Pull Request

The JSON-LD contains "jobLocationType": "Onsite" (or "Hybrid" / "Telecommute"), which Google flags as invalid.

Expected result AFTER applying this Pull Request

Onsite: no jobLocationType in the output, only jobLocation. Hybrid and Telecommute: "jobLocationType": "TELECOMMUTE", with the physical jobLocation still present for Hybrid.

Link to documentations

Please select:

  • No documentation changes for guide.joomla.org needed

  • No documentation changes for manual.joomla.org needed

Made with Cursor

avatar Otto-Deviant1904 Otto-Deviant1904 - open - 13 Aug 2026
avatar Otto-Deviant1904 Otto-Deviant1904 - change - 13 Aug 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2026
Category Front End Plugins Unit Tests
avatar muhme muhme - test_item - 14 Aug 2026 - Tested successfully
avatar muhme
muhme - comment - 14 Aug 2026

I have tested this item ✅ successfully on 649c916

* Tested with JBT

avatar muhme
muhme - comment - 14 Aug 2026

I have tested this item ✅ successfully on 649c916

* Tested with JBT

avatar ThomasFinnern ThomasFinnern - test_item - 14 Aug 2026 - Tested successfully
avatar ThomasFinnern
ThomasFinnern - comment - 14 Aug 2026

I have tested this item ✅ successfully on 649c916

Test results:

  • Onsite: "jobLocationType": "Onsite", line removed
  • Telecommute: unchanged
  • Hybrid: unchanged

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48238.
avatar ThomasFinnern
ThomasFinnern - comment - 14 Aug 2026

I have tested this item ✅ successfully on 649c916

Test results:

  • Onsite: "jobLocationType": "Onsite", line removed
  • Telecommute: unchanged
  • Hybrid: unchanged

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48238.
avatar muhme muhme - change - 14 Aug 2026
The description was changed
Status Pending Ready to Commit
avatar muhme
muhme - comment - 14 Aug 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48238.

avatar muhme muhme - edited - 14 Aug 2026
avatar muhme
muhme - comment - 14 Aug 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48238.

avatar richard67 richard67 - change - 23 Aug 2026
Labels Added: RTC Unit/System Tests bug PR-5.4-dev
avatar richard67 richard67 - alter_testresult - 23 Aug 2026 - muhme: Tested successfully
avatar richard67 richard67 - alter_testresult - 23 Aug 2026 - ThomasFinnern: Tested successfully
avatar richard67 richard67 - test_item - 23 Aug 2026 - Tested successfully
avatar richard67
richard67 - comment - 23 Aug 2026

I have tested this item ✅ successfully on ad13f30

Final test before merging: The PR does what it says, which is consistent to what is described here https://developers.google.com/search/docs/appearance/structured-data/job-posting , and the results are valid according to Google's Rich Results Test validator https://search.google.com/test/rich-results .


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48238.

avatar richard67
richard67 - comment - 23 Aug 2026

I have tested this item ✅ successfully on ad13f30

Final test before merging: The PR does what it says, which is consistent to what is described here https://developers.google.com/search/docs/appearance/structured-data/job-posting , and the results are valid according to Google's Rich Results Test validator https://search.google.com/test/rich-results .


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48238.

avatar richard67 richard67 - close - 23 Aug 2026
avatar richard67 richard67 - merge - 23 Aug 2026
avatar richard67 richard67 - change - 23 Aug 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-08-23 18:24:15
Closed_By richard67
avatar richard67
richard67 - comment - 23 Aug 2026

Thanks @Otto-Deviant1904 for this PR, and @muhme and @ThomasFinnern for testing.

avatar Otto-Deviant1904
Otto-Deviant1904 - comment - 24 Aug 2026

Thanks @richard67 for merging, and thanks @muhme and @ThomasFinnern for the thorough testing — really appreciated. Happy to keep contributing around the schema.org plugins; there are a few more spec-compliance gaps worth tidying up (I'll open issues as I confirm them).

avatar Otto-Deviant1904
Otto-Deviant1904 - comment - 24 Aug 2026

Thanks @richard67 for merging, and thanks to @muhme and @ThomasFinnern for testing this one. Happy to keep contributing around the schema.org plugins too. I noticed a couple more spec compliance gaps while working on this PR so I will open issues as I confirm them.

Add a Comment

Login with GitHub to post a comment