[#48212] - [5.4] Fix days_of_week normalization (shorter version)
- Fixed in Code Base
- 9 Aug 2026
- Medium
- Build: 5.4-dev
- # 48212
- Diff
- tecpromotion:fix/fix-days-week-taskmodel-54
User tests: Successful: Unsuccessful:
Pull Request resolves requested updates for #47708
Fixes #47647
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
see #47708
Testing Instructions
see #47708
Actual result BEFORE applying this Pull Request
wrong date for the next run
Expected result AFTER applying this Pull Request
correct date for the next run
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
@tecpromotion I've allowed myself to add the link to the issue at the top of the PR description so GitHub will close the issue when this PR will be merged.
should match the standard cron setting for days
What do you mean? cron (depending which implementation) accepts 0 and 7 as sunday. So it's perfectly fine to use 1 to 7 and solves our problem without much effort, because this here is actually a typo. In the validation code we check for 1-7.
should match the standard cron setting for days
What do you mean? cron (depending which implementation) accepts 0 and 7 as sunday. So it's perfectly fine to use 1 to 7 and solves our problem without much effort, because this here is actually a typo. In the validation code we check for 1-7.
I have tested this item ✅ successfully on 71e0b45
Checked "Next Execution time" and db. Both changed after 'save' according to description
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48212.
I have tested this item ✅ successfully on 71e0b45
Checked "Next Execution time" and db. Both changed after 'save' according to description
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48212.
I have tested this item ✅ successfully on 71e0b45
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48212.
I have tested this item ✅ successfully on 71e0b45
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48212.
should match the standard cron setting for days
What do you mean? cron (depending which implementation) accepts 0 and 7 as sunday. So it's perfectly fine to use 1 to 7 and solves our problem without much effort, because this here is actually a typo. In the validation code we check for 1-7.
I agree with @HLeithner here.
When you select only Sunday in the cron expression in the form and save, the weekday value is saved as 7 in database. See here for why: https://github.com/joomla/joomla-cms/blob/5.4-dev/administrator/components/com_scheduler/src/Field/CronField.php#L51-L57
The cron rule form of the task does not allow to enter a complete cron expression in a text field, it only allows to select the particular components of that expression with distinct fields, e.g. weekday Monday, Tuesday and so on.
So the resulting cron rule is just an internal representation which the end user never will see, and here we are free to chose if we use 0 or 7 for Sunday. No need to support both.
should match the standard cron setting for days
What do you mean? cron (depending which implementation) accepts 0 and 7 as sunday. So it's perfectly fine to use 1 to 7 and solves our problem without much effort, because this here is actually a typo. In the validation code we check for 1-7.
I agree with @HLeithner here.
When you select only Sunday in the cron expression in the form and save, the weekday value is saved as 7 in database. See here for why: https://github.com/joomla/joomla-cms/blob/5.4-dev/administrator/components/com_scheduler/src/Field/CronField.php#L51-L57
The cron rule part of the task form does not allow to enter a complete cron expression in a text field, it only allows to select the particular components of that expression with distinct fields, e.g. weekday Monday, Tuesday and so on.
So the resulting cron rule is just an internal representation which the end user never will see, and here we are free to chose if we use 0 or 7 for Sunday. No need to support both.
should match the standard cron setting for days
What do you mean? cron (depending which implementation) accepts 0 and 7 as sunday. So it's perfectly fine to use 1 to 7 and solves our problem without much effort, because this here is actually a typo. In the validation code we check for 1-7.
I agree with @HLeithner here.
When you select only Sunday in the cron expression in the form and save, the weekday value is saved as 7 in database. See also here: https://github.com/joomla/joomla-cms/blob/5.4-dev/administrator/components/com_scheduler/src/Field/CronField.php#L51-L57
The cron rule part of the task form does not allow to enter a complete cron expression in a text field, it only allows to select the particular components of that expression with distinct fields, e.g. weekday Monday, Tuesday and so on.
So the resulting cron rule is just an internal representation which the end user never will see, and here we are free to chose if we use 0 or 7 for Sunday. No need to support both.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-5.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48212.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48212.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-08-09 13:25:03 |
| Closed_By | ⇒ | richard67 |
Thanks @tecpromotion for this PR, and @ThomasFinnern and @HLeithner for testing.
should match the standard cron setting for days