[#48205] - [5.4] Fix to display nested tags with path in Menu Item Tagged Items
- Pending
- Medium
- Build: 5.4-dev
- # 48205
- Diff
- pe7er:fix-menu-item-tagged-items-tags
User tests: Successful: Unsuccessful:
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
This PR improves the UX with the Menu Item Type "Tagged Items" for nested Tags because you cannot distinguish Nested Tags:
In the Article edit you can easily distinguish Nested Tags, because the Tags are displayed with the full path:
Testing Instructions
Create Tags
In Components > Tags ( /administrator/index.php?option=com_tags&view=tags ),
create some nested Tags with the same name but different alias like:
- English/Joomla/Templates (alias: templates)
- Nederlands/Joomla/Templates (alias: templates-nl)
Create Menu Item of type "Tagged Items"
In Menus > Main Menu ( /administrator/index.php?option=com_menus&view=items&menutype=mainmenu )
- create a new Menu Item of Menu Item Type "Tags" > "Tagged Items"
- under "Tag" select both the nested "Templates" Tags
Actual result BEFORE applying this Pull Request
Both tags are shown as "Templates", so it is not possible to see which one belongs to which parent:
Expected result AFTER applying this Pull Request
Both tags are shown with their full path, for example English/Joomla/Templates, which is the same behaviour as the tags field in the article edit form:
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I can see the problem you are describing but this also impacts the display of the tags in the selector. Its now harder to see the tree. is it possible to keep the dropdown display as is. Or maybe i am getting confused between using tags in ajax/nested mode
before
after
I can see the problem you are describing but this also impacts the display of the tags in the selector. Its now harder to see the tree. is it possible to keep the dropdown display as is. Or maybe i am getting confused between using tags in ajax/nested mode - it looks like this kills the nested mode entirely but doesnt remove the setting?
before
after
When selecting a tag the display in the dropdown is dependant on the data entry mode
Before This PR
Nested
Ajax
With this PR
the nested mode displays exactly the same as the ajax mode
I have tested this item 🔴 unsuccessfully on 4d17fe1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48205.
I have tested this item 🔴 unsuccessfully on 4d17fe1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48205.
seem that this needs to be fixed/changed in the layout
seem that this needs to be fixed/changed in the layout
beside that I would rebase this the solution to 6.2 because it's not a bug, it's an optimization and the issue already exists ages.
beside that I would rebase this the solution to 6.2 because it's not a bug, it's an optimization and the issue already exists ages.
I agree with @HLeithner . @pe7er Please rebase to 6.2-dev.
beside that I would rebase this the solution to 6.2 because it's not a bug, it's an optimization and the issue already exists ages.
I agree with @HLeithner . @pe7er Please rebase to 6.2-dev. See also https://github.com/joomla/joomla-cms#which-branch-should-my-pull-request-target
I can see the problem you are describing but this also impacts the display of the tags in the selector. Its now harder to see the tree. is it possible to keep the dropdown display as is
before
after