[#48204] - [6.2] Detailed Error-Message when upload of SVG-Files is not possible
- Ready to Commit
- Medium
- Build: 6.2-dev
- # 48204
- Diff
- torstenhoppe:svg_error-msg
User tests: Successful: Unsuccessful:
Pull Request resolves #38532 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Improvements to the information displayed in MediaManager when uploading SVG files.
The code has been amended and additional language variables have been created for the upload process in both the backend and the frontend.
Testing Instructions
https://guide.joomla.org/user-manual/media/media-media-uploading-svg-files
@brianteeman add link to generate SVG-Files
#48204 (comment)
Actual result BEFORE applying this Pull Request
The current output does not provide detailed information on why the SVG file cannot be uploaded, but merely states that the file cannot be loaded.
The SVG file format is essentially an XML file, so it may contain many instructions that could potentially cause security issues. As it is an open format and many applications add their own attributes – which do not actually pose a security risk and can be removed manually in an editor – detailed information on the reason why the upload was rejected is helpful for further investigation.
Expected result AFTER applying this Pull Request
You will receive the information as before, along with details of which attribute cannot be processed.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org: https://guide.joomla.org/user-manual/media
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Libraries |
Looks good to me
Before
After
For anyone testing you can generate a dirty.svg file by creating an svg file with the dirty data from here https://svg.enshrined.co.uk/
| Labels |
Added:
Language Change
PR-6.2-dev
|
||
did you intend to commit those two svg files
I have tested this item ✅ successfully on 8c499f0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48204.
I have tested this item ✅ successfully on 8c499f0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48204.
tecpromotion
- | Title |
|
||||||
I have tested this item ✅ successfully on 4fd320f
with my private *.svg file i got successfull error messages like
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48204.
I have tested this item ✅ successfully on 4fd320f
with my private *.svg file i got successfull error messages like
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48204.
I have tested this item ✅ successfully on 4fd320f
with my private *.svg file i got successfull error messages like
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48204.
I've restored @brianteeman 's test result in the issue tracker as the commit which has invalidated his test was just a small change without impact on functionality, see 4fd320f .
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48204.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48204.
Looks good to me
Before
After