[#48146] - [5.4] [AI] Fix empty subforms, division by zero
- Closed
- 29 Jul 2026
- Medium
- Build: 5.4-dev
- # 48146
- Diff
- chmst:54-fix-empty-subform
User tests: Successful: Unsuccessful:
Pull Request resolves #48118 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
If a subform is empty (has no fields) then display an information.
Testing Instructions
Make a textfield.
Make a subform and add this field.
Then trash the textfield.
Actual result BEFORE applying this Pull Request
A division by zero occurs as described in the issue #48118, if the table layout is chosen
Expected result AFTER applying this Pull Request
Information is displayed:
Remark: division by zero occurs only for the table layout.
But also for other subform field it is an improvement.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Layout |
| Labels |
Added:
Language Change
PR-5.4-dev
|
||
From a11y point of view, the solution is not correct. There is a fom-control with a label, but no input field.
The check for empty subform must be earlier.
| Category | Administration Language & Strings Layout | ⇒ | Administration Language & Strings Layout Libraries |
If a subform is empty, no control-group is rendered, only an information alert.
This avoids a label which does not belong to an input.
If a subform is empty, no control-group is rendered, only an information alert. Supportedd by co-pilot.
This avoids a label which does not belong to an input.
| Title |
|
||||||
The changes looks realy strange tbh :)
The changes looks realy strange tbh :)
Addittionaly it could be a "visual b.c. break" for existing sites.
I would just display nothing.
Maintainers decided to fix the bug with a small hotfix in 5.4 and resolve the a11y issue in 6.2.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-07-29 18:00:32 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
bug
|
||
From a11y point of view, the solution is not corret.
The check for empty subform must be earlier.