[#48134] - [6.2] Use class names instead of strings for container resources
- Pending
- Medium
- Build: 6.2-dev
- # 48134
- Diff
- Digital-Peak:classnames
User tests: Successful: Unsuccessful:
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Using real class names for resource lookup improves readability and static code analyzers can properly detect the returned class. Our PHPStan setup can correctly identify resources from the container get functions when it is a real class, so this pr changes the few occurrences, where the alias is used in core.
@wilsonge you might want to have a look here
Testing Instructions
- Enable the cache plugin
- Open a page on the front
- Check if there is a page cache entry in /administrator/index.php?option=com_cache
Actual result BEFORE applying this Pull Request
Page loads from cache and entry in cache manager exists.
Expected result AFTER applying this Pull Request
Page loads from cache and entry in cache manager exists.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation Libraries Front End Plugins |
The caching logic is not touched, only the serving of the document. But I added the extra line.
| Labels |
Added:
PR-6.2-dev
Architecture
|
||
Could you add a testing instruction how to validate, that cache is hit?