User tests: Successful: Unsuccessful:
Pull Request resolves # .
This pull request introduces a safeguard to the file installation process in the FileAdapter installer, preventing accidental copying of all files from a package root to the site root.
It also fixes an error if no fileset is available in manifest file (for example, if everything is handled separately via an installer script).
folder and target attributesUnfortunately, this error message occurs only sporadically and cannot always be reproduced.
However, the PHP error can be traced at this point.FileAdapter.php#L505
These files can be found in the root of the site:
fileadaptertest.php
fileadaptertest.xml
i_should_not_be_in_root.txt
LICENSE
README.md
No 'JSON.parse: unexpected character at line 1 column 1 of the JSON data' - error message.
If you visit the frontend using the standard Cassiopeia template, you should see this message

Or alternatively, this comment in the index.php in the cassiopeia template code - line 13.
defined('_JEXEC') or die;
// I should be here to ensure fileadaptertest script is working correctly.
You should see the same for the template index.php override in Cassiopeia template like in case 1.
<files folder="test" target="fatest1"></files>
fatest1with the following file
i_should_be_here.txt<files folder="test"></files>
New file under root on the site i_should_be_here.txt
<files target="fatest2"></files>
fatest2 with the following files
<files>test/i_should_be_here.txt</files>
New file under root on the site i_should_be_here.txt
<files></files>
You should see this warning message
These files should not be copied to the root of the site:
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration Language & Strings Libraries |
I have tested this item ✅ successfully on 83c1019
Tested on 5.4.8-dev Works as expected
Found different message on test case 1 without patch applied
I have tested this item ✅ successfully on 83c1019
Tested on 5.4.8-dev Works as expected
Found different message on test case 1 without patch applied

I have tested this item ✅ successfully on 83c1019
Tested on 5.4.8-dev Works as expected
Found different message on test case 1 without patch applied
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48121.