[#48108] - [5.4] Fix failing build on forks
- Fixed in Code Base
- 18 Jul 2026
- Medium
- Build: 5.4-dev
- # 48108
- Diff
- ramalama:fix/fix-48107
User tests: Successful: Unsuccessful:
Pull Request resolves #48107 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
added check for empty git diff before trying to add/commit an empty file list.
Testing Instructions
In a forked repo (joomla/joomla-cms is excluded from this mechanic):
- Create a branch with a change that doesnt introduce any problems that php-cs-fixer can fix.
- Create a PR for the change
Actual result BEFORE applying this Pull Request
ci run fails at csfixer as desribed in #48107
Expected result AFTER applying this Pull Request
ci run does not fail at csfixer anymore if no changes are produced by it
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
tecpromotion
- 
I have tested this item ✅ successfully on e430176
I've successfully verified the issue and tested this PR.
First I have updated the 5.4-dev branch of my fork of the CMS repo to the 5.4-dev branch of the CMS repo by using the branch synch on GitHub.
That reproduces the issue.
In the log of the ci action, step "Check PHP code style":
Fixed 0 of 2600 files in 29.160 seconds, 42.00 MB memory used
On branch 5.4-dev
Your branch is up to date with 'origin/5.4-dev'.
nothing to commit, working tree clean
Error: Process completed with exit code 1.
Then I have created a branch in my fork which is equal to the branch of this PR and have made one commit with a change without any PHP code style relevance.
In the log of the ci action, step "Check PHP code style":
Fixed 0 of 2600 files in 23.358 seconds, 44.00 MB memory used
Then I have pushed a commit to that branch which created a PHP code style issue.
In the log of the ci action, step "Check PHP code style":
1) administrator/components/com_actionlogs/src/Controller/ActionlogsController.php (braces_position)
---------- begin diff ----------
--- /__w/joomla-cms/joomla-cms/administrator/components/com_actionlogs/src/Controller/ActionlogsController.php
+++ /__w/joomla-cms/joomla-cms/administrator/components/com_actionlogs/src/Controller/ActionlogsController.php
@@ -73,8 +73,7 @@
$pks = [];
- if ($task == 'exportSelectedLogs')
- {
+ if ($task == 'exportSelectedLogs') {
// Get selected logs
$pks = ArrayHelper::toInteger(explode(',', $this->input->post->getString('cids')));
}
----------- end diff -----------
Fixed 1 of 2600 files in 31.559 seconds, 44.00 MB memory used
[5.4-dev-test-pr-48108-step2 6e0e6f4] Fix code style issues [skip ci]
1 file changed, 1 insertion(+), 2 deletions(-)
To https://github.com/richard67/joomla-cms
f603e5e..6e0e6f4 HEAD -> 5.4-dev-test-pr-48108-step2
The CI action has created a commit in that branch with the PHP code style fix: richard67@6e0e6f4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48108.
I have tested this item ✅ successfully on e430176
I've successfully verified the issue and tested this PR.
First I have updated the 5.4-dev branch of my fork of the CMS repo to the 5.4-dev branch of the CMS repo by using the branch synch on GitHub.
That reproduces the issue.
In the log of the ci action, step "Check PHP code style":
Fixed 0 of 2600 files in 29.160 seconds, 42.00 MB memory used
On branch 5.4-dev
Your branch is up to date with 'origin/5.4-dev'.
nothing to commit, working tree clean
Error: Process completed with exit code 1.
Then I have created a branch in my fork which is equal to the branch of this PR and have made one commit with a change without any PHP code style relevance.
In the log of the ci action, step "Check PHP code style":
Fixed 0 of 2600 files in 23.358 seconds, 44.00 MB memory used
Then I have pushed a commit to that branch which created a PHP code style issue.
In the log of the ci action, step "Check PHP code style":
1) administrator/components/com_actionlogs/src/Controller/ActionlogsController.php (braces_position)
---------- begin diff ----------
--- /__w/joomla-cms/joomla-cms/administrator/components/com_actionlogs/src/Controller/ActionlogsController.php
+++ /__w/joomla-cms/joomla-cms/administrator/components/com_actionlogs/src/Controller/ActionlogsController.php
@@ -73,8 +73,7 @@
$pks = [];
- if ($task == 'exportSelectedLogs')
- {
+ if ($task == 'exportSelectedLogs') {
// Get selected logs
$pks = ArrayHelper::toInteger(explode(',', $this->input->post->getString('cids')));
}
----------- end diff -----------
Fixed 1 of 2600 files in 31.559 seconds, 44.00 MB memory used
[5.4-dev-test-pr-48108-step2 6e0e6f4] Fix code style issues [skip ci]
1 file changed, 1 insertion(+), 2 deletions(-)
To https://github.com/richard67/joomla-cms
f603e5e..6e0e6f4 HEAD -> 5.4-dev-test-pr-48108-step2
The CI action has created a commit in that branch with the PHP code style fix: richard67@6e0e6f4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48108.
| Labels |
Added:
PR-5.4-dev
|
||
![avatar github-actions[bot]](/images/avatars/github-actions[bot].png)
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-07-18 11:43:01 |
| Closed_By | ⇒ | richard67 |
@laoneo @Hackwar Hope this helps.