RTC PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar adarshdubey03
adarshdubey03
14 Jul 2026

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Removes the duplicate no matching results alert from the Installed Languages view. The shared SearchTools layout already renders the no results message when the search returns no records. The Installed Languages template was rendering the same message again, resulting in two identical alerts.

Testing Instructions

  1. Go to installed languages.
  2. Search a thing that has no results.

Actual result BEFORE applying this Pull Request

Two identical alerts.

Expected result AFTER applying this Pull Request

Only one alert.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar adarshdubey03 adarshdubey03 - open - 14 Jul 2026
avatar adarshdubey03 adarshdubey03 - change - 14 Jul 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jul 2026
Category Administration com_languages
avatar adarshdubey03 adarshdubey03 - change - 14 Jul 2026
Title
fix duplicate no results message in installed languages
[6.1] fix duplicate no results message in installed languages
avatar adarshdubey03 adarshdubey03 - edited - 14 Jul 2026
avatar brianteeman
brianteeman - comment - 14 Jul 2026

as this is a bug fix shouldnt it be made against the j5 branch?

avatar brianteeman
brianteeman - comment - 14 Jul 2026

its strange that this is needed as almost every other table has the code you are removing here. Are your sure that code is the problem

avatar adarshdubey03
adarshdubey03 - comment - 14 Jul 2026

@brianteeman The installed languages filter already defines noresults="JGLOBAL_NO_MATCHING_RESULTS", so SearchTools renders the alert when the total is zero. Other list templates with a manual no results alert do not define this attribute. Here, the template renders the same alert again, causing the duplication.

avatar brianteeman
brianteeman - comment - 14 Jul 2026

Wouldn't it be better then to remove it from the search tools so that the layout for this view is consistent with all other views

avatar adarshdubey03 adarshdubey03 - change - 14 Jul 2026
Labels Added: PR-6.1-dev
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jul 2026
Category Administration com_languages Administration com_languages com_media NPM Change JavaScript Repository Front End com_content Installation Language & Strings
avatar github-actions[bot]
github-actions[bot] - comment - 14 Jul 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

avatar adarshdubey03 adarshdubey03 - change - 14 Jul 2026
Title
[6.1] fix duplicate no results message in installed languages
[5.4] fix duplicate no results message in installed languages
avatar adarshdubey03 adarshdubey03 - edited - 14 Jul 2026
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jul 2026
Category Administration com_languages com_media NPM Change JavaScript Repository Front End com_content Installation Language & Strings Administration com_languages
avatar adarshdubey03 adarshdubey03 - change - 14 Jul 2026
Labels Added: Conflicting Files PR-5.4-dev
avatar hiteshm0 hiteshm0 - test_item - 15 Jul 2026 - Tested successfully
avatar hiteshm0
hiteshm0 - comment - 15 Jul 2026

I have tested this item ✅ successfully on 41bd1e7

Testing instructions verified.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48088.

avatar hiteshm0
hiteshm0 - comment - 15 Jul 2026

I have tested this item ✅ successfully on 41bd1e7

Testing instructions verified.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48088.

avatar QuyTon QuyTon - test_item - 15 Jul 2026 - Tested successfully
avatar QuyTon
QuyTon - comment - 15 Jul 2026

I have tested this item ✅ successfully on 41bd1e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48088.

avatar QuyTon
QuyTon - comment - 15 Jul 2026

I have tested this item ✅ successfully on 41bd1e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48088.

avatar QuyTon QuyTon - change - 15 Jul 2026
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 15 Jul 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48088.

avatar QuyTon
QuyTon - comment - 15 Jul 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48088.

avatar brianteeman
brianteeman - comment - 15 Jul 2026
avatar brianteeman
brianteeman - comment - 15 Jul 2026
avatar muhme muhme - change - 17 Jul 2026
Labels Added: RTC
Removed: Conflicting Files PR-6.1-dev
avatar muhme
muhme - comment - 17 Jul 2026

✅ Final test before merge with JBT

  • Seen doubled 'No Matching Results' before PR
  • Applied PR with Patch Tester
    • Seen only one 'No Matching Results' info line
    • Search is still working
avatar muhme muhme - change - 17 Jul 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-07-17 13:31:47
Closed_By muhme
avatar muhme muhme - close - 17 Jul 2026
avatar muhme muhme - merge - 17 Jul 2026
avatar muhme
muhme - comment - 17 Jul 2026

Thank you very much @adarshdubey03 for your contribution. Thank you @brianteeman for supporting. Thanks to @hiteshm0 and @QuyTon for testing.

Add a Comment

Login with GitHub to post a comment