User tests: Successful: Unsuccessful:
Pull Request resolves # .
Removes the duplicate no matching results alert from the Installed Languages view. The shared SearchTools layout already renders the no results message when the search returns no records. The Installed Languages template was rendering the same message again, resulting in two identical alerts.
Two identical alerts.
Only one alert.
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_languages |
| Title |
|
||||||
its strange that this is needed as almost every other table has the code you are removing here. Are your sure that code is the problem
@brianteeman The installed languages filter already defines noresults="JGLOBAL_NO_MATCHING_RESULTS", so SearchTools renders the alert when the total is zero. Other list templates with a manual no results alert do not define this attribute. Here, the template renders the same alert again, causing the duplication.
Wouldn't it be better then to remove it from the search tools so that the layout for this view is consistent with all other views
| Labels |
Added:
PR-6.1-dev
|
||
| Category | Administration com_languages | ⇒ | Administration com_languages com_media NPM Change JavaScript Repository Front End com_content Installation Language & Strings |
This pull request has conflicts, please resolve those before we can evaluate the pull request.
| Title |
|
||||||
| Category | Administration com_languages com_media NPM Change JavaScript Repository Front End com_content Installation Language & Strings | ⇒ | Administration com_languages |
| Labels |
Added:
Conflicting Files
PR-5.4-dev
|
||
I have tested this item ✅ successfully on 41bd1e7
Testing instructions verified.
I have tested this item ✅ successfully on 41bd1e7
Testing instructions verified.
I have tested this item ✅ successfully on 41bd1e7
I have tested this item ✅ successfully on 41bd1e7
| Status | Pending | ⇒ | Ready to Commit |
RTC
RTC
| Labels |
Added:
RTC
Removed: Conflicting Files PR-6.1-dev |
||
✅ Final test before merge with JBT
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-07-17 13:31:47 |
| Closed_By | ⇒ | muhme |
Thank you very much @adarshdubey03 for your contribution. Thank you @brianteeman for supporting. Thanks to @hiteshm0 and @QuyTon for testing.
as this is a bug fix shouldnt it be made against the j5 branch?