[#48077] - [6.2] Use text column for finder routes
- Pending
- Medium
- Build: 6.2-dev
- # 48077
- Diff
- MacJoom:5.2-dev
User tests: Successful: Unsuccessful:
Summary of Changes
Change the Smart Search #__finder_links.route column from varchar(400) to ext for MySQL and PostgreSQL.
This prevents Smart Search indexing from failing when generated routes exceed the previous 400 character limit.
Supersedes #44414.
Testing Instructions
Use a site with article aliases close to 400 characters and run the Smart Search indexing process from Components, Smart Search, Index.
Actual result BEFORE applying this Pull Request
The indexing process can fail with a database error similar to Data too long for column 'route' at row 1.
Expected result AFTER applying this Pull Request
The index is built without failing because of long route values.
Link to documentations
No documentation changes needed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql Installation |
I have tested this item ✅ successfully on 07dca15
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48077.
I'm not really happy with this change. The consensus is that the safe maximum number of characters in a URL is 2048. A normal non-SEF Joomla URL should not be more than maybe 100 characters and maybe there are situations where we could turn a blind eye to 200 or even 300 characters, but non-SEF URLs with more than 400 characters are simply a sign of a broken architecture. I don't want to support that to be honest.
I have tested this item 🔴 unsuccessfully on 07dca15
The length of an article alias was limited to 344 characters during my tests.
The indexing process would not fail even if the PR was not yet applied.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48077.
I have tested this item 🔴 unsuccessfully on 07dca15
The length of an article alias was limited to 344 characters during my tests.
The indexing process would not fail even if the PR was not yet applied.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48077.
"Text" columns are saved physically on another location and makes the query slower, so I would extend the varchar in this case.
better change the field to 2048 and hope that nobody finds out that get requests doesn't have a length limit.
com_finder also has its install SQL in the component folder and thus that would have to be adapted as well. Again, I don't think changing this field is a good idea and instead the affected components should change their routing, but it isn't the hill I'm going to die on.
I have tested this item ✅ successfully on 07dca15
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48077.