User tests: Successful: Unsuccessful:
components/com_modules/src/Dispatcher/Dispatcher.php has a code style violation: inside the checkAccess() method the authorise() condition is indented with 11 spaces instead of 12.
Because the file lives in 5.4-dev (the module.edit.frontend check was introduced there and does not exist in 5.3), the php-cs-fixer CI job re-fixes this line on every unrelated pull request and appends the change to that PR's diff (e.g. it showed up in the translation PR #48066). This corrects the indentation once so it stops polluting other PRs.
Change is whitespace-only, no functional impact:
if (
- !$this->app->getIdentity()->authorise('module.edit.frontend', 'com_modules')
+ !$this->app->getIdentity()->authorise('module.edit.frontend', 'com_modules')
) {vendor/bin/php-cs-fixer fix components/com_modules/src/Dispatcher/Dispatcher.php --config=.php-cs-fixer.dist.php --dry-run --diffphp-cs-fixer reports the file as fixable (1 of 1) and wants to change the indentation.
php-cs-fixer reports Found 0 of 1 files that can be fixed — the file is already compliant.
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Front End com_modules |
| Title |
|
||||||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-07-09 08:50:24 |
| Closed_By | ⇒ | muhme | |
| Labels |
Added:
PR-5.4-dev
|
||
Thank you very much @tecpromotion for your contribution.