PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar tecpromotion
tecpromotion
9 Jul 2026
  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

components/com_modules/src/Dispatcher/Dispatcher.php has a code style violation: inside the checkAccess() method the authorise() condition is indented with 11 spaces instead of 12.

Because the file lives in 5.4-dev (the module.edit.frontend check was introduced there and does not exist in 5.3), the php-cs-fixer CI job re-fixes this line on every unrelated pull request and appends the change to that PR's diff (e.g. it showed up in the translation PR #48066). This corrects the indentation once so it stops polluting other PRs.

Change is whitespace-only, no functional impact:

         if (
-           !$this->app->getIdentity()->authorise('module.edit.frontend', 'com_modules')
+            !$this->app->getIdentity()->authorise('module.edit.frontend', 'com_modules')
         ) {

Testing Instructions

  1. Check out this branch.
  2. Run the code style check against the file:
    vendor/bin/php-cs-fixer fix components/com_modules/src/Dispatcher/Dispatcher.php --config=.php-cs-fixer.dist.php --dry-run --diff

Actual result BEFORE applying this Pull Request

php-cs-fixer reports the file as fixable (1 of 1) and wants to change the indentation.

Expected result AFTER applying this Pull Request

php-cs-fixer reports Found 0 of 1 files that can be fixed — the file is already compliant.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar tecpromotion tecpromotion - open - 9 Jul 2026
avatar tecpromotion tecpromotion - change - 9 Jul 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jul 2026
Category Front End com_modules
avatar tecpromotion tecpromotion - change - 9 Jul 2026
The description was changed
avatar tecpromotion tecpromotion - edited - 9 Jul 2026
avatar tecpromotion tecpromotion - change - 9 Jul 2026
Title
[5.4] Fix code style in com_modules frontend Dispatcher
[5.4] [AI] Fix code style in com_modules frontend Dispatcher
avatar tecpromotion tecpromotion - edited - 9 Jul 2026
avatar muhme muhme - change - 9 Jul 2026
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-07-09 08:50:24
Closed_By muhme
Labels Added: PR-5.4-dev
avatar muhme muhme - close - 9 Jul 2026
avatar muhme muhme - merge - 9 Jul 2026
avatar muhme
muhme - comment - 9 Jul 2026

Thank you very much @tecpromotion for your contribution.

Add a Comment

Login with GitHub to post a comment