Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
5 Jul 2026
  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

This converts all calls to getError() in controllers to instead use exceptions.

Testing Instructions

Codereview

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 5 Jul 2026
avatar Hackwar Hackwar - change - 5 Jul 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jul 2026
Category Administration com_banners com_config com_contact com_content com_contenthistory com_finder com_installer com_languages com_menus com_messages com_redirect com_templates com_users com_workflow
avatar richard67
richard67 - comment - 6 Jul 2026

@Hackwar Phpstan complains about the „setUseException“ calls. Don’t we want to remove them in 7.0?

avatar Hackwar
Hackwar - comment - 6 Jul 2026

No, those are the helpers to allow for transitioning from LegacyErrorHandlingTrait to Exceptions and they will only be removed in 8.0. They are mandatory to convert to exceptions now.

avatar richard67
richard67 - comment - 6 Jul 2026

No, those are the helpers to allow for transitioning from LegacyErrorHandlingTrait to Exceptions and they will only be removed in 8.0. They are mandatory to convert to exceptions now.

Then you should adapt the phpstan baseline file in this PR because as you can see, phpstan fails for this PR.

avatar Hackwar
Hackwar - comment - 6 Jul 2026

I've done something better and instead fixed it already in #47261. So it would be nice if that one could be merged and then this one here will also pass, similar to a few others in the future.

Add a Comment

Login with GitHub to post a comment