Feeling Lucky
?
[#4803] - Wrapper class for JHttpFactory to get rid of static methods
- Closed
- 18 Oct 2014
- Medium
- Build: 3.4-dev
- # 4803
- Diff
- Kubik-Rubik:wrapper-static-methods-joomla-http
- Success The Travis CI build passed Details
Related to
# 4717
User tests: Successful: Unsuccessful:
Reference: #4717
This PR introduces a wrapper class for the JHttpFactory class to get rid of the static methods to improve the testing basis of the code for our PHPUnit tests!
The static methods (and the wrappers) will be removed completely in Joomla! 4.x.
jissues-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Unit Tests |
| Rel_Number | ⇒ | 4717 | |
| Relation Type | ⇒ | Related to |
mbabker
- comment
- 18 Oct 2014
Factories too can be objects, see JDatabaseFactory.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-18 09:18:26 |
| Milestone |
Added: |
||
I think the JHttpFactory::getHttp() is effectively a getInstance() method. There's no point in wrapping it you just initiate a new version of JHttp yourself......