User tests: Successful: Unsuccessful:
Pull Request resolves #47976
This PR fixes an issue where categories containing exclusively future-published items (or items with an expired publish_down date) are incorrectly counted as having active items, causing them to be improperly displayed in frontend category lists and modules
Implementation:
check_dates opt-in parameter to the core Joomla\CMS\Categories\Categories::_load() method. When enabled, the item-counting subquery strictly enforces publish_up and publish_down window conditions.$options['check_dates'] = true; in the Category service constructors for com_content, com_contact, com_banners, and com_newsfeeds, as these core components actively utilize scheduled publishing dates.The category with the not yet published articles is displayed in the subcategories list


The category with the not yet published articles is not displayed in the subcategories list

Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Front End com_banners com_contact com_content com_newsfeeds Libraries |
@brianteeman should i remove the changes made to the banner component?
although letting it be would make things more consistent with negligible performance overhead.
Consistency is good. I just wondered if the fix could be made earlier so it doesn't have to be repeated but if not then this is fine.
| Title |
|
||||||
Thanks for you pr, I rebased this to 6.2 since it might not be expected behaviour I think doing this change in a patch release is an unexpected output change and would like to not do such things in a patch version.
| Title |
|
||||||
This pull request has conflicts, please resolve those before we can evaluate the pull request.
| Labels |
Added:
Conflicting Files
PR-6.2-dev
|
||
| Labels |
Removed:
Conflicting Files
|
||
It's good that you used this in all components that use categories but it's probably not needed in banners as I don't think there is any scenario where that would happen