RTC bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
20 Jun 2026

Pull Request resolves #47992 .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

used whereNotIn in where condition

Testing Instructions

see #47992

Actual result BEFORE applying this Pull Request

Filter by unactivated does not work

Expected result AFTER applying this Pull Request

You can filter by both states

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 20 Jun 2026
avatar alikon alikon - change - 20 Jun 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jun 2026
Category Administration com_users
avatar alikon alikon - change - 20 Jun 2026
The description was changed
avatar alikon alikon - edited - 20 Jun 2026
avatar alikon alikon - change - 20 Jun 2026
Title
Change activation query condition for users
[5.4] com_users unable to filter by unactivated users state
avatar alikon alikon - edited - 20 Jun 2026
avatar brianteeman brianteeman - test_item - 20 Jun 2026 - Tested successfully
avatar brianteeman
brianteeman - comment - 20 Jun 2026

I have tested this item ✅ successfully on 0677de2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47993.

avatar brianteeman
brianteeman - comment - 20 Jun 2026

I have tested this item ✅ successfully on 0677de2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47993.

avatar alikon alikon - change - 21 Jun 2026
Labels Added: bug PR-5.4-dev
avatar QuyTon QuyTon - test_item - 21 Jun 2026 - Tested successfully
avatar QuyTon
QuyTon - comment - 21 Jun 2026

I have tested this item ✅ successfully on f0c60ef


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47993.

avatar QuyTon
QuyTon - comment - 21 Jun 2026

I have tested this item ✅ successfully on f0c60ef


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47993.

avatar tecpromotion
tecpromotion - comment - 22 Jun 2026

@brianteeman could you please test that again after the code changes? Thanks.

avatar brianteeman
brianteeman - comment - 22 Jun 2026

Sorry I can't test as I am away from a pc for the next few Weeks

avatar exlemor exlemor - test_item - 22 Jun 2026 - Tested successfully
avatar exlemor
exlemor - comment - 22 Jun 2026

I have tested this item ✅ successfully on f0c60ef

I was able to test this successfully (at 30,000 feet in the air while heading West).

Thanks @alikon.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47993.

avatar exlemor
exlemor - comment - 22 Jun 2026

I have tested this item ✅ successfully on f0c60ef

I was able to test this successfully (at 30,000 feet in the air while heading West).

Thanks @alikon.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47993.

avatar richard67 richard67 - change - 22 Jun 2026
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 22 Jun 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47993.

avatar richard67
richard67 - comment - 22 Jun 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47993.

avatar muhme muhme - change - 23 Jun 2026
Labels Added: RTC
avatar muhme
muhme - comment - 23 Jun 2026

✅ Final Test before merge with JBT

  • Created some activated users in backend, enabled user registration and created two not activated users
  • Before PR
    • ⚠️ Selection of activated and not activated users works, guessing as the database field activation is set with token e.g. 707faeda8ba6f534d42e79bbb2843808
    • If I set activation field with 1, user is shown as not activated and selecting is not working as described in the issue
  • Applied PR with Patch Tester
    • ✅ Selection of activated and not activated users is possible with activation key or value 1
    • Email verification with the string is still working for the user, admin is getting registration approval email and for admin it is possible to activate the user with the given link from email, user can login
avatar muhme muhme - change - 23 Jun 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-06-23 08:54:10
Closed_By muhme
avatar muhme muhme - close - 23 Jun 2026
avatar muhme muhme - merge - 23 Jun 2026
avatar muhme
muhme - comment - 23 Jun 2026

Thank you very much @alikon for your contribution. Thank you @QuyTon for your reviews and testing. Thank you @exlemor for testing.

Add a Comment

Login with GitHub to post a comment