User tests: Successful: Unsuccessful:
Pull Request resolves # .
Requires / depends on: #47985
Without that PR the language string is never loaded, so this change has no visible effect on its own.
The security log message of the "Authentication - Cookie" plugin is defined as:
PLG_AUTHENTICATION_COOKIE_ERROR_LOG_LOGIN_FAILED="Cookie login failed for user %u."
It is emitted in onUserAuthenticate() via
Text::sprintf('PLG_AUTHENTICATION_COOKIE_ERROR_LOG_LOGIN_FAILED', $results[0]->user_id).
The value passed in comes from #__user_keys.user_id, which actually holds the username (a string) — see onUserAfterLogin(), which stores $options['user']->username in that column. The %u specifier formats its
argument as an unsigned integer, so a (non-numeric) username is converted to 0 and the log always reads "… for user 0.", which does not identify the account.
This PR changes the placeholder from %u to %s so the actual username is logged. Only the en-GB source string is changed; other languages follow through the normal translation workflow.
Apply #47985 first, otherwise the
string stays untranslated and this change cannot be observed.
administrator/logs/everything.php, category security).#__user_keys and a joomla_remember_me_* cookie).security entry in the log.WARNING 127.0.0.1 security Cookie login failed for user 0.
(the real username instead of 0)
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration Language & Strings |
I have tested this item ✅ successfully on 197aea9
I have tested this item ✅ successfully on 197aea9
I have tested this item ✅ successfully on 197aea9
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
Language Change
PR-5.4-dev
|
||
RTC
RTC
| Labels |
Added:
RTC
|
||
✅ Final test before merge with JBT:
Cookie login failed for user 0. beforeCookie login failed for user ci-admin.Thank you very much @tecpromotion for your contribution. Thanks to @brianteeman and @CSGoat0 for testing.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-06-19 16:15:04 |
| Closed_By | ⇒ | muhme |
I have tested this item ✅ successfully on 197aea9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47986.