RTC Language Change bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar tecpromotion
tecpromotion
19 Jun 2026

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Requires / depends on: #47985
Without that PR the language string is never loaded, so this change has no visible effect on its own.

The security log message of the "Authentication - Cookie" plugin is defined as:

PLG_AUTHENTICATION_COOKIE_ERROR_LOG_LOGIN_FAILED="Cookie login failed for user %u."

It is emitted in onUserAuthenticate() via
Text::sprintf('PLG_AUTHENTICATION_COOKIE_ERROR_LOG_LOGIN_FAILED', $results[0]->user_id).

The value passed in comes from #__user_keys.user_id, which actually holds the username (a string) — see onUserAfterLogin(), which stores $options['user']->username in that column. The %u specifier formats its
argument as an unsigned integer, so a (non-numeric) username is converted to 0 and the log always reads "… for user 0.", which does not identify the account.

This PR changes the placeholder from %u to %s so the actual username is logged. Only the en-GB source string is changed; other languages follow through the normal translation workflow.

Testing Instructions

Apply #47985 first, otherwise the
string stays untranslated and this change cannot be observed.

  1. Enable the "Authentication - Cookie" plugin and make sure error logging is on (administrator/logs/everything.php, category security).
  2. On the frontend, log in with "Remember Me" checked (creates a row in #__user_keys and a joomla_remember_me_* cookie).
  3. In the browser dev tools, edit that cookie: change the part before the dot (the token), keep the part after the dot (the series) unchanged.
  4. Reload a frontend page so the cookie authentication runs.
  5. Look at the security entry in the log.

Actual result BEFORE applying this Pull Request

WARNING 127.0.0.1 security Cookie login failed for user 0.

Expected result AFTER applying this Pull Request

(the real username instead of 0)

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar tecpromotion tecpromotion - open - 19 Jun 2026
avatar tecpromotion tecpromotion - change - 19 Jun 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jun 2026
Category Administration Language & Strings
avatar brianteeman brianteeman - test_item - 19 Jun 2026 - Tested successfully
avatar brianteeman
brianteeman - comment - 19 Jun 2026

I have tested this item ✅ successfully on 197aea9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47986.

avatar brianteeman
brianteeman - comment - 19 Jun 2026

I have tested this item ✅ successfully on 197aea9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47986.

avatar CSGoat0 CSGoat0 - test_item - 19 Jun 2026 - Tested successfully
avatar CSGoat0
CSGoat0 - comment - 19 Jun 2026

I have tested this item ✅ successfully on 197aea9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47986.

avatar CSGoat0
CSGoat0 - comment - 19 Jun 2026

I have tested this item ✅ successfully on 197aea9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47986.

avatar richard67 richard67 - change - 19 Jun 2026
Status Pending Ready to Commit
Labels Added: bug Language Change PR-5.4-dev
avatar richard67
richard67 - comment - 19 Jun 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47986.

avatar richard67
richard67 - comment - 19 Jun 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47986.

avatar muhme muhme - change - 19 Jun 2026
Labels Added: RTC
avatar muhme
muhme - comment - 19 Jun 2026

✅ Final test before merge with JBT:

  • Seen Cookie login failed for user 0. before
  • Applied PR with Patch Tester, seen Cookie login failed for user ci-admin.
avatar muhme
muhme - comment - 19 Jun 2026

Thank you very much @tecpromotion for your contribution. Thanks to @brianteeman and @CSGoat0 for testing.

avatar muhme muhme - change - 19 Jun 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-06-19 16:15:04
Closed_By muhme
avatar muhme muhme - close - 19 Jun 2026
avatar muhme muhme - merge - 19 Jun 2026

Add a Comment

Login with GitHub to post a comment