[#47978] - [5.4] Fix potential issue with update multiple extensions
- Fixed in Code Base
- 19 Jun 2026
- Medium
- Build: 5.4-dev
- # 47978
- Diff
- joomdonation:fix_update_multiple_extensions_fail
User tests: Successful: Unsuccessful:
Pull Request resolves #47536, #41087
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Please see #47536 for details information of the issue. We did code review and confirm that the proposed fix is valid.
Testing Instructions
It is not easy to provide testing instructions. However, from code reading, we can see that it is a valid fix. The issue comes from the way we use a single installer object, but this fix makes sense anyway
@laoneo also got this issue and confirmed that the fix fixed the issue on his site.
Actual result BEFORE applying this Pull Request
Update multiple extensions fail in some special conditions as described in the issue
Expected result AFTER applying this Pull Request
No issues with update multiple extensions
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-5.4-dev
|
||
I have tested this item ✅ successfully on cd11660
On a production site this patch fixes the issue, when I want to update packages and plugins together where one plugin has a manifest file and a subsequent one not.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47978.
I have tested this item ✅ successfully on cd11660
On a production site this patch fixes the issue, when I want to update packages and plugins together where one plugin has a manifest file and a subsequent one not.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47978.
You need to reset the $this->manifest_script as well, as this is causing mainly the trouble
I have tested this item ✅ successfully on 48c0cbd
On a production site this patch fixes the issue, when I want to update packages and plugins together where one plugin has a manifest file and a subsequent one not.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47978.
I have tested this item ✅ successfully on 48c0cbd
On a production site this patch fixes the issue, when I want to update packages and plugins together where one plugin has a manifest file and a subsequent one not.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47978.
Extensions to install:
Without patch:
With patch:
Extensions to install:
Without patch gets DPMedia core package deleted from site:
With patch:
| Labels |
Added:
bug
|
||
@Ruud68 Could you please help testing this PR and confirm that it fixes the issue you reported ? This is not easy (or more accurate will take much time) for me to prepare a good testing instructions for testers, so it would be great if you could help testing it. Thanks
Hi @joomdonation thanks for reaching out.
I have tested this code (from my closed issue) when I was in a position to test months ago:
// When no script file, reset any previously set manifestClass and do nothing
if (!$manifestScript) {
$this->parent->manifestClass = null;
return;
}
That worked.
currently I do not have a test environment where I can reproduce this: I have implemented a workaround for all my extensions / plugins / packages.
Looking at you PR I see that you use the same code, so based on that I say 'Go'
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-06-19 14:15:52 |
| Closed_By | ⇒ | richard67 |
Thanks @joomdonation for this PR, and @laoneo for testing, and @Ruud68 for review.
I have tested this item ✅ successfully on cd11660
On a production site this patch fixes the issue, when I want to update packages and plugins together where one plugin has a manifest file and a subsequent one not.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47978.