[#47966] - [5.4] Show readmore in mod_articles when introtext_limit truncates text
- Pending
- Medium
- Build: 5.4-dev
- # 47966
- Diff
- rish106-hub:fix/47710-mod-articles-readmore-introtext-limit
User tests: Successful: Unsuccessful:
Pull Request resolves #47710.
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
PR #47263 fixed readmore showing when there is nothing to read, but introduced a regression: when introtext_limit is used to truncate text (instead of a readmore marker), $item->fulltext is empty so the readmore button never renders even though the article IS truncated and there IS more to read.
Fix tracks whether truncation actually occurred and uses that flag alongside $item->fulltext to decide readmore visibility.
Testing Instructions
- Create an article with only introtext (no readmore marker), body > 100 chars
- Create a mod_articles module: set Introtext Limit = 50, Show Read More = Yes
- View frontend — readmore button should appear
- Shorten article text below limit — readmore button should disappear
- Article with readmore marker — unaffected, still shows readmore
Actual result BEFORE applying this PR
No readmore button shown even though text is truncated by introtext_limit
Expected result AFTER applying this PR
Readmore button appears when introtext is truncated. Does not appear when text fits within limit. Articles using readmore marker unaffected.
- No documentation changes for guide.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
@richard67 Thanks for flagging #47713.
Our approach differs in a key way: #47713 has an open review comment from @QuyTon noting the fix executes even when show_introtext is disabled.
In this PR, $item->introTextTruncated is initialized to false in the helper and only set to true inside the if ($show_introtext) block — so the template condition is always safe when intro text display is off. This addresses QuyTon's concern.
Happy to close if maintainers prefer to update #47713 instead.
I have tested this item ✅ successfully on 5621400
Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47966.
I have tested this item ✅ successfully on 5621400
Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47966.
@richard67 — adding to my earlier response:
@krishnagandhicode has independently tested and confirmed this PR works correctly on 5621400.
To summarise why this PR addresses the regression more completely than #47713:
- #47713 has an open review comment from @QuyTon: the fix runs even when
show_introtextis disabled - In this PR,
$item->introTextTruncatedis initialised tofalsebefore theif ($show_introtext)block and is only settrueinside it — so when intro text display is off, the flag staysfalseand the readmore condition is unaffected
With a passing test and CI green, happy to have this reviewed for merge or to close in favour of a corrected #47713 — whichever the team prefers.
@richard67 — adding to my earlier response:
@krishnagandhicode has independently tested and confirmed this PR works correctly on 5621400.
To summarise why this PR addresses the regression more completely than #47713:
- #47713 has an open review comment from @QuyTon: the fix runs even when
show_introtextis disabled - In this PR,
$item->introTextTruncatedis initialised tofalsebefore theif ($show_introtext)block and is only settrueinside it - so when intro text display is off, the flag staysfalseand the readmore condition is unaffected
With a passing test and CI green, happy to have this reviewed for merge or to close in favour of a corrected #47713 - whichever the team prefers.
I have tested this item ✅ successfully on 5621400
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47966.
I have tested this item ✅ successfully on 5621400
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47966.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47966.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47966.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending as updates are requested
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47966.
Back to pending as updates are requested
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47966.
| Labels |
Added:
Updates Requested
PR-5.4-dev
|
||
Addressed both review suggestions from @QuyTon:
ArticlesHelper.php: Removed redundant parentheses around the boolean comparison -
$item->introTextTruncated = $truncated !== $item->displayIntrotext;default_items.php: Replaced!empty($item->introTextTruncated)with$item->introTextTruncateddirectly, since the property is already a boolean and!empty()is unnecessary here.
@krishnagandhicode @alikon Could one of you do a quick retest if it still works with the latest changes? I would assume yes by review, but to play safe, one retest would be nice and should be sufficient for adding back RTC.
| Labels |
Added:
bug
Removed: Updates Requested |
||
There is already a PR for the same issue: #47713 .