Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
14 Jun 2026

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

The BannerModel still uses deprecated method Factory::getCache to create cache controller. This PR updates code to use the injected cache controller factory to create cache controller instead.

Testing Instructions

  • Use Joomla 6.2
  • Go to System -> Global Configuration, System tab, set System Cache to one of the two ON options
  • Create one or two banners if no banners created before
  • Create an instance of Banners module, publish it in a module position in frontend of your site
  • Visit frontend of your site, see the module, click on the banner
  • Make sure you still being redirected to the URL associated with the banner

Actual result BEFORE applying this Pull Request

Works, but uses deprecated code

Expected result AFTER applying this Pull Request

Works, without using deprecated code

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomdonation joomdonation - open - 14 Jun 2026
avatar joomdonation joomdonation - change - 14 Jun 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jun 2026
Category Front End com_banners

Add a Comment

Login with GitHub to post a comment