User tests: Successful: Unsuccessful:
Cleanup deprecation
basically renamed the public onDisplay method in editor button plugins to getButton and make it private.
onDisplay was initially not a plugin event instead it has been called directly by the editor plugin.
Open tinymce or other editor which support the button plugins
works
still should work
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org: joomla/Manual#649
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Front End Plugins |
| Labels |
Added:
PR-7.0-dev
|
||
Some of the buttons were marked as deprecated but some of them were not
it also says
* @deprecated 5.0 Use onEditorButtonsSetup event instead, will be removed in 7.0
did I missed the text somewherE?
I have tested this item ✅ successfully on 34fba3a
Looks good to me
I have tested this item ✅ successfully on 34fba3a
Looks good to me
| Status | Pending | ⇒ | Ready to Commit |
RTC
RTC
| Labels |
Added:
RTC
|
||
Wondering what extensions should use then as replacement?
Wondering what extensions should use then as replacement?
This pull request has conflicts, please resolve those before we can evaluate the pull request.
| Labels |
Added:
Conflicting Files
|
||
| Labels |
Removed:
Conflicting Files
|
||
| Labels |
Added:
b/c break
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-06-06 15:26:22 |
| Closed_By | ⇒ | laoneo |
Some of the buttons were marked as deprecated but some of them were not
it also says
* @deprecated 5.0 Use onEditorButtonsSetup event instead, will be removed in 7.0