RTC b/c break PR-7.0-dev Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
6 Jun 2026

Cleanup deprecation

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

basically renamed the public onDisplay method in editor button plugins to getButton and make it private.

onDisplay was initially not a plugin event instead it has been called directly by the editor plugin.

Testing Instructions

Open tinymce or other editor which support the button plugins

Actual result BEFORE applying this Pull Request

works

Expected result AFTER applying this Pull Request

still should work

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual#649

  • No documentation changes for manual.joomla.org needed

avatar HLeithner HLeithner - open - 6 Jun 2026
avatar HLeithner HLeithner - change - 6 Jun 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jun 2026
Category Front End Plugins
avatar github-actions[bot] github-actions[bot] - change - 6 Jun 2026
Labels Added: PR-7.0-dev
avatar brianteeman
brianteeman - comment - 6 Jun 2026

Some of the buttons were marked as deprecated but some of them were not

it also says

* @deprecated 5.0 Use onEditorButtonsSetup event instead, will be removed in 7.0

avatar HLeithner HLeithner - change - 6 Jun 2026
The description was changed
avatar HLeithner HLeithner - edited - 6 Jun 2026
avatar HLeithner
HLeithner - comment - 6 Jun 2026

Some of the buttons were marked as deprecated but some of them were not

it also says

* @deprecated 5.0 Use onEditorButtonsSetup event instead, will be removed in 7.0

did I missed the text somewherE?

avatar joomdonation joomdonation - test_item - 6 Jun 2026 - Tested successfully
avatar joomdonation
joomdonation - comment - 6 Jun 2026

I have tested this item ✅ successfully on 34fba3a

Looks good to me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47902.

avatar joomdonation
joomdonation - comment - 6 Jun 2026

I have tested this item ✅ successfully on 34fba3a

Looks good to me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47902.

avatar joomdonation joomdonation - change - 6 Jun 2026
Status Pending Ready to Commit
avatar joomdonation
joomdonation - comment - 6 Jun 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47902.

avatar joomdonation
joomdonation - comment - 6 Jun 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47902.

avatar laoneo laoneo - change - 6 Jun 2026
Labels Added: RTC
avatar laoneo
laoneo - comment - 6 Jun 2026

Wondering what extensions should use then as replacement?

avatar laoneo
laoneo - comment - 6 Jun 2026

Wondering what extensions should use then as replacement?

avatar github-actions[bot]
github-actions[bot] - comment - 6 Jun 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

avatar laoneo laoneo - change - 6 Jun 2026
Labels Added: Conflicting Files
avatar laoneo laoneo - change - 6 Jun 2026
Labels Removed: Conflicting Files
avatar laoneo laoneo - change - 6 Jun 2026
Labels Added: b/c break
avatar laoneo laoneo - change - 6 Jun 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-06-06 15:26:22
Closed_By laoneo
avatar laoneo laoneo - close - 6 Jun 2026
avatar laoneo laoneo - merge - 6 Jun 2026

Add a Comment

Login with GitHub to post a comment