Feeling Lucky
?
[#4787] - Batch process pop-up gets open even without selection
- Closed
- 8 Nov 2014
- Medium
- Build: staging
- # 4787
- Diff
- garima-agal:staging
- Failure The Travis CI build failed Details
Related to
# 4754
Referenced as
Related to:
# 4754
User tests: Successful: Unsuccessful:
. We can apply validation, to make selection first
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | UI/UX |
| Title |
|
||||||
| Rel_Number | ⇒ | 4754 | |||||
| Relation Type | ⇒ | Related to | |||||
allanlhansen
- 
brianteeman
- comment
- 17 Oct 2014
@losedk the UX sprint last year tried to get that sort of change in and it was rejected. :(
On the basis of two good tests I am setting this RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4787.
| Status | Pending | ⇒ | Ready to Commit |
losedk
- comment
- 17 Oct 2014
@brianteeman ahh okay :S
zero-24
- comment
- 17 Oct 2014
@garima-agal It looks like we have a failed Travis test:
There was 1 failure:
1) JToolbarButtonHelpTest::testFetchButton
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<button onclick="Joomla.popupWindow('help/en-GB/JHELP_CONTENT_ARTICLE_MANAGER.html', 'JHELP', 700, 500, 1)" rel="help" class="btn btn-small">
+'<button onclick="Joomla.popupWindow('help/en-GB/Content_Article_Manager.html', 'Help', 700, 500, 1)" rel="help" class="btn btn-small">
<span class="icon-question-sign"></span>
- JTOOLBAR_HELP</button>
+ Help</button>
'
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/toolbar/button/JToolbarButtonHelpTest.php:102
See: https://travis-ci.org/joomla/joomla-cms/jobs/38266232
Can you have a look into it?
vijaykhollam
- 
sandeepghule
- 
phproberto
- | Status | Ready to Commit | ⇒ | Needs Review |
Bakual
- comment
- 8 Nov 2014
Merged, thanks.
After some tests in my fork I came to the conclusion that the failed tests must be due to some outdated branch and not related to the PR.
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-08 16:46:28 |
Works fine. Perhaps we should take it a step further at hide the batch button until something is selected?