User tests: Successful: Unsuccessful:
Pull Request resolves # .
This pull request (PR) removes an obsolete exclusion for files in the build/media_source/vendor/tinymce/langs folder from the .github/workflows/typos.toml file, which is the configuration file for the "CI Joomla / Check for typos (pull_request)" CI action.
The language files in that folder don't exists in Joomla 6.x and later with TinyMCE 8.
So this exclusion is only relevant for 5.4-dev and not needed for later versions.
Code review, and check if there is the mentioned folder after a composer installand an npm ci on a current 6.1-dev branch.
Check that the "CI Joomla / Check for typos (pull_request)" CI action succeeeds for this PR.
The .github/workflows/typos.toml file contains an obsolte exclusion for files in the build/media_source/vendor/tinymce/langs folder.
The .github/workflows/typos.toml file doesn't contain that obsolete exclusion anymore.
The "CI Joomla / Check for typos (pull_request)" CI action succeeeds for this PR.
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Repository |
Don't you need to add a new exclusion for the new tinymce language location or is that already excluded?
@brianteeman They don't need to be excluded as they are in the media/vendor/tinymce/langs folder, which exists only after an npm ci, but the typo check runs on the bare sources without composer and npm.
I have tested this item ✅ successfully on fb7868f
I have tested this item ✅ successfully on fb7868f
I have tested this item ✅ successfully on fb7868f
I have tested this item ✅ successfully on fb7868f
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-6.1-dev
|
||
RTC
RTC
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-05-26 19:10:55 |
| Closed_By | ⇒ | tecpromotion | |
| Labels |
Added:
RTC
|
||
Thanks @richard67 and all testers
Don't you need to add a new exclusion for the new tinymce language location or is that already excluded?