RTC PR-6.1-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
25 May 2026

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

This pull request (PR) removes an obsolete exclusion for files in the build/media_source/vendor/tinymce/langs folder from the .github/workflows/typos.toml file, which is the configuration file for the "CI Joomla / Check for typos (pull_request)" CI action.

The language files in that folder don't exists in Joomla 6.x and later with TinyMCE 8.

So this exclusion is only relevant for 5.4-dev and not needed for later versions.

Testing Instructions

Code review, and check if there is the mentioned folder after a composer installand an npm ci on a current 6.1-dev branch.

Check that the "CI Joomla / Check for typos (pull_request)" CI action succeeeds for this PR.

Actual result BEFORE applying this Pull Request

The .github/workflows/typos.toml file contains an obsolte exclusion for files in the build/media_source/vendor/tinymce/langs folder.

Expected result AFTER applying this Pull Request

The .github/workflows/typos.toml file doesn't contain that obsolete exclusion anymore.

The "CI Joomla / Check for typos (pull_request)" CI action succeeeds for this PR.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 25 May 2026
avatar richard67 richard67 - change - 25 May 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2026
Category Repository
avatar brianteeman
brianteeman - comment - 25 May 2026

Don't you need to add a new exclusion for the new tinymce language location or is that already excluded?

avatar richard67
richard67 - comment - 25 May 2026

Don't you need to add a new exclusion for the new tinymce language location or is that already excluded?

@brianteeman They don't need to be excluded as they are in the media/vendor/tinymce/langs folder, which exists only after an npm ci, but the typo check runs on the bare sources without composer and npm.

avatar brianteeman brianteeman - test_item - 25 May 2026 - Tested successfully
avatar brianteeman
brianteeman - comment - 25 May 2026

I have tested this item ✅ successfully on fb7868f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47831.

avatar brianteeman
brianteeman - comment - 25 May 2026

I have tested this item ✅ successfully on fb7868f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47831.

avatar QuyTon QuyTon - test_item - 26 May 2026 - Tested successfully
avatar QuyTon
QuyTon - comment - 26 May 2026

I have tested this item ✅ successfully on fb7868f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47831.

avatar QuyTon
QuyTon - comment - 26 May 2026

I have tested this item ✅ successfully on fb7868f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47831.

avatar QuyTon QuyTon - change - 26 May 2026
Status Pending Ready to Commit
Labels Added: PR-6.1-dev
avatar QuyTon
QuyTon - comment - 26 May 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47831.

avatar QuyTon
QuyTon - comment - 26 May 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47831.

avatar tecpromotion tecpromotion - close - 26 May 2026
avatar tecpromotion tecpromotion - merge - 26 May 2026
avatar tecpromotion tecpromotion - change - 26 May 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-05-26 19:10:55
Closed_By tecpromotion
Labels Added: RTC
avatar tecpromotion
tecpromotion - comment - 26 May 2026

Thanks @richard67 and all testers

Add a Comment

Login with GitHub to post a comment