[#47825] - [5.4] Update typos GitHub action to v1.46.3
- Fixed in Code Base
- 27 May 2026
- Medium
- Build: 5.4-dev
- # 47825
- Diff
- richard67:5.4-dev-update-gh-actions-typos
User tests: Successful: Unsuccessful:
Pull Request resolves # .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
This pull request (PR) updates the GitHub action "crate-ci/typos" in our CI workflow from version v1.34.0 to version v1.46.3.
See changelog https://github.com/crate-ci/typos/blob/master/CHANGELOG.md .
New typos found by the new version are corrected, as far as that is possible without any b/c break or deprecation rule violation:
- Typos "inititializes", "santitizer" and "trigering" are corrected in code comments.
- Typo "writeable" is corrected in code comments and language string values.
For typos which can't be fixed without any b/c break or deprecation rule violation, eclusions are added to the .github/workflows/typos.toml file:
- Typo "fobidden" is used in the option name "fobidden_ext_in_content" in
Joomla\CMS\Filter\InputFilter. - "wrkarounds" is used in method parameter names
$wrkaroundsin diverseJoomla\CMS\Cache\Controllercontroller classes. It's not really a typo for a variable name but a valid short form (saves 1 character length). - Typo "LANUAGES" is used in the language string key
COM_CONFIG_HEADING_LANUAGESin theadministrator/language/en-GB/com_config.inifile.
This language string was added with PR #22126 to Joomla 4.0.
But I haven't found any direct use of this string and the other 2 starting withCOM_CONFIG_HEADING_in the core.
This has to be checked more in detail, so the questionable string or all 3 can be deprecated and be removed in the right versions.
Testing Instructions
Code review, and check that the "CI Joomla / Check for typos (pull_request)" action is successful for this PR.
Actual result BEFORE applying this Pull Request
GitHub action "crate-ci/typos" is outdated.
Expected result AFTER applying this Pull Request
GitHub action "crate-ci/typos" is up to date.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
PR-5.4-dev
|
||
| Category | Repository | ⇒ | Repository Libraries |
| Category | Repository Libraries | ⇒ | Repository Administration Libraries |
| Category | Repository Libraries Administration | ⇒ | Repository Administration com_admin com_config com_joomlaupdate Libraries Front End Plugins |
| Category | Repository Libraries Administration com_admin com_config com_joomlaupdate Front End Plugins | ⇒ | Repository Administration com_admin com_config com_joomlaupdate Language & Strings Libraries Front End Plugins |
| Labels |
Added:
Language Change
|
||
not at my pc today (its 35c here) so cant check the first part but agree on the two exceptions
| Title |
|
||||||
@richard67 looking at #22126 I can see that those strings were used in the first commit but subsequently unused when the code was refactored before the pr was finally merged.
I suggest that all the strings added in #22126 are checked to see if they are being used and if not then they should be marked as deprecated for removal in 7.0
@richard67 looking at #22126 I can see that those strings were used in the first commit but subsequently unused when the code was refactored before the pr was finally merged.
I suggest that all the strings added in #22126 are checked to see if they are being used and if not then they should be marked as deprecated for removal in 7.0
Unfortunately I won’t have time in the next days to check all these strings.
But that should not stop this PR here.
Do I assume right that we have to depreciate the unused strings in 6.2-dev for removal in 7.0?
I would deprecate them in 5.4 as they've never been used but I leave that to others to decide.
This pr is good to go
I have tested this item ✅ successfully on ce949ef
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47825.
I have tested this item ✅ successfully on ce949ef
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47825.
| Status | Pending | ⇒ | Ready to Commit |
RTC after 1 successful test and 1 approval by a maintainer.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47825.
RTC after 1 successful test and 1 approval by a maintainer.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47825.
| Labels |
Added:
RTC
|
||
✅ Before merge only scanned the changes and checked CI passed.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-05-27 15:41:50 |
| Closed_By | ⇒ | muhme |
Thank you very much @richard67 for your contribution. Thank you @brianteeman for your support and testing. Thank you @tecpromotion for review.
@brianteeman Maybe you can advise what to do with the remaining typos?
This comes from the language string key
COM_CONFIG_HEADING_LANUAGESin theadministrator/language/en-GB/com_config.inifiles.I did not find the 3 strings
COM_CONFIG_HEADING_COMPONENT,COM_CONFIG_HEADING_DESCRIPTIONandCOM_CONFIG_HEADING_LANUAGESbeing used anywhere in the core.Do you know if they are used somewhere?
And should we add exclusions for those in the
.github/workflows/typos.tomlfile?These come from method parameter names
$wrkaroundsand option namesfobidden_ext_in_content. I think we can't change that as it would be a b/c break.I think we have to add exclusions for those in the
.github/workflows/typos.tomlfile. Do you agree?