User tests: Successful: Unsuccessful:
.after some reading up I found up that maximum allowed URL in IE is 2083, other browsers allow much higher numbers, even over 100.000, but we must stand with the lowest one, so I set it up for 2083.
Example description here: http://www.boutell.com/newfaq/misc/urllength.html
In this PR I have removed unique constraint. When we insert new row we are actually doing this check inside of the Joomla code, so this is not needed. And it was making a trouble because maximum varchar key for unique key is 767. So while removing it for mysql, I removed it for all DBs because as stated above, it is not needed.
Please check this code against Postgre and sqlazure if possible.
Labels |
Added:
?
|
Title |
|
Category | ⇒ | Components Installation MS SQL Postgresql SQL |
Title |
|
Title |
|
Title |
|
||||||
Rel_Number | ⇒ | 4692 | |||||
Relation Type | ⇒ | Related to |
Successful test, for reference test instructions are:
Check _redirect_links structure view to see the fields old_url, new_url and referer are all of type varchar(255).
Apply patch
Go to Extensions Manager>Database and apply 'fix' (note I had one left over where it was trying to change back to 255 when on 3.3.7-dev, may be a quirk)
All fields old_url, new_url and referer should now be varchar(2083)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4781.
Labels |
Added:
?
|
@test OK, following @RCheesley steps, structure modified successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4781.
Two good tests thanks setting RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4781.
Status | Pending | ⇒ | Ready to Commit |
This cannot be merged anymore. Also maybe we need to do it against v3.4-dev branch renaming sql files properly
Status | Ready to Commit | ⇒ | Needs Review |
@kixo please can you update your PR as it can no longer be merged. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4781.
@brianteeman updated
Labels |
Removed:
?
|
@test failed for mssql
Please add the closing ) in installation/sql/sqlazure/joomla.sql line 2364.
Unrelated to that but found in the course of testing: Saving a link in the redirect component gives an error when using postgresql or mssql as database because NULL cannot be inserted into column "referer".
There is another small problem. In 3.4.0-2014-09-16.sql
ALTER TABLE #__redirect_links
MODIFY new_url varchar(255);
results in this problem - when you update the database schema via "Extension manager" > Database > Fix:
Table 'uy937_redirect_links' does not have column 'new_url' with type 'varchar(255)'. (From file 3.4.0-2014-09-16.sql.)
So this line could be deleted.
That column is supposed to be in the table (see https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L1517).
Of course, but there is a conflict with this statement in 3.4.0-2014-10-17.sql
ALTER TABLE #__redirect_links
CHANGE new_url
new_url
varchar(2083) NOT NULL;
The proposed solution was to delete
ALTER TABLE #__redirect_links MODIFY new_url varchar(255);
in 3.4.0-2014-09-16.sql.
ok updated
Status | Needs Review | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-01 14:07:28 |
Closed_By | ⇒ | brianteeman |
ok
after some reading up I found up that maximum allowed URL in IE is 2083, other browsers allow much higher numbers, even over 100.000, but we must stand with the lowest one, so I set it up for 2083.
Example description here: http://www.boutell.com/newfaq/misc/urllength.html
In this PR I have removed unique constraint. When we insert new row we are actually doing this check inside of the Joomla code, so this is not needed. And it was making a trouble because maximum varchar key for unique key is 767. So while removing it for mysql, I removed it for all DBs because as stated above, it is not needed.
Please check this code against Postgre and sqlazure if possible.
http://issues.joomla.org/tracker/joomla-cms/4692