? Success
Related to # 4692

User tests: Successful: Unsuccessful:

avatar Kixo
Kixo
17 Oct 2014

.after some reading up I found up that maximum allowed URL in IE is 2083, other browsers allow much higher numbers, even over 100.000, but we must stand with the lowest one, so I set it up for 2083.
Example description here: http://www.boutell.com/newfaq/misc/urllength.html

In this PR I have removed unique constraint. When we insert new row we are actually doing this check inside of the Joomla code, so this is not needed. And it was making a trouble because maximum varchar key for unique key is 767. So while removing it for mysql, I removed it for all DBs because as stated above, it is not needed.

Please check this code against Postgre and sqlazure if possible.

avatar Kixo Kixo - open - 17 Oct 2014
avatar jissues-bot jissues-bot - change - 17 Oct 2014
Labels Added: ?
avatar Kixo
Kixo - comment - 17 Oct 2014

ok

after some reading up I found up that maximum allowed URL in IE is 2083, other browsers allow much higher numbers, even over 100.000, but we must stand with the lowest one, so I set it up for 2083.
Example description here: http://www.boutell.com/newfaq/misc/urllength.html

In this PR I have removed unique constraint. When we insert new row we are actually doing this check inside of the Joomla code, so this is not needed. And it was making a trouble because maximum varchar key for unique key is 767. So while removing it for mysql, I removed it for all DBs because as stated above, it is not needed.

Please check this code against Postgre and sqlazure if possible.

http://issues.joomla.org/tracker/joomla-cms/4692

avatar jissues-bot jissues-bot - change - 17 Oct 2014
Title
4692_com_redirect_adding_urls_larger_than_255
4692 com_redirect adding urls larger than 255
avatar zero-24 zero-24 - change - 17 Oct 2014
Category Components Installation MS SQL Postgresql SQL
avatar zero-24 zero-24 - change - 17 Oct 2014
The description was changed
Title
4692_com_redirect_adding_urls_larger_than_255
4692 com_redirect adding urls larger than 255
avatar jissues-bot jissues-bot - change - 17 Oct 2014
Title
4692 com_redirect adding urls larger than 255
com_redirect adding urls larger than 255
avatar brianteeman brianteeman - change - 17 Oct 2014
The description was changed
Title
4692 com_redirect adding urls larger than 255
com_redirect adding urls larger than 255
Rel_Number 4692
Relation Type Related to
avatar RCheesley RCheesley - test_item - 17 Oct 2014 - Tested successfully
avatar RCheesley
RCheesley - comment - 17 Oct 2014

Successful test, for reference test instructions are:

  1. Check _redirect_links structure view to see the fields old_url, new_url and referer are all of type varchar(255).

  2. Apply patch

  3. Go to Extensions Manager>Database and apply 'fix' (note I had one left over where it was trying to change back to 255 when on 3.3.7-dev, may be a quirk)

  4. All fields old_url, new_url and referer should now be varchar(2083)

    This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4781.

avatar nicksavov nicksavov - change - 17 Oct 2014
Labels Added: ?
avatar anibalsanchez
anibalsanchez - comment - 17 Oct 2014

@test OK, following @RCheesley steps, structure modified successfully.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4781.

avatar brianteeman brianteeman - alter_testresult - 17 Oct 2014 - anibalsanchez: Tested successfully
avatar brianteeman
brianteeman - comment - 17 Oct 2014

Two good tests thanks setting RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4781.

avatar brianteeman brianteeman - change - 17 Oct 2014
Status Pending Ready to Commit
avatar twssachin twssachin - test_item - 18 Oct 2014 - Tested successfully
avatar sandeepghule sandeepghule - test_item - 18 Oct 2014 - Tested successfully
avatar phproberto
phproberto - comment - 24 Oct 2014

This cannot be merged anymore. Also maybe we need to do it against v3.4-dev branch renaming sql files properly

avatar phproberto phproberto - change - 24 Oct 2014
Status Ready to Commit Needs Review
avatar brianteeman
brianteeman - comment - 27 Nov 2014

@kixo please can you update your PR as it can no longer be merged. Thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4781.

avatar Kixo
Kixo - comment - 28 Nov 2014

@brianteeman updated

avatar brianteeman brianteeman - change - 1 Jan 2015
Labels Removed: ?
avatar waader
waader - comment - 9 Jan 2015

@test failed for mssql

Please add the closing ) in installation/sql/sqlazure/joomla.sql line 2364.

Unrelated to that but found in the course of testing: Saving a link in the redirect component gives an error when using postgresql or mssql as database because NULL cannot be inserted into column "referer".

avatar Kixo
Kixo - comment - 26 Jan 2015

thanks for testing @waader I uninstalled mssql so I did not test changes for the second time.
I have updated the PR with corrected SQL.

avatar waader
waader - comment - 27 Jan 2015

There is another small problem. In 3.4.0-2014-09-16.sql

ALTER TABLE #__redirect_links MODIFY new_url varchar(255);

results in this problem - when you update the database schema via "Extension manager" > Database > Fix:

Table 'uy937_redirect_links' does not have column 'new_url' with type 'varchar(255)'. (From file 3.4.0-2014-09-16.sql.)

So this line could be deleted.

avatar mbabker
mbabker - comment - 27 Jan 2015
avatar waader
waader - comment - 27 Jan 2015

Of course, but there is a conflict with this statement in 3.4.0-2014-10-17.sql

ALTER TABLE #__redirect_links CHANGE new_url new_url varchar(2083) NOT NULL;

avatar Kixo
Kixo - comment - 6 Mar 2015

@waader I am not exactly sure what the problem is. Can you please explain in more detail or propose the solution.

avatar waader
waader - comment - 6 Mar 2015

The proposed solution was to delete

ALTER TABLE #__redirect_links MODIFY new_url varchar(255);

in 3.4.0-2014-09-16.sql.

avatar Kixo
Kixo - comment - 6 Mar 2015

ok updated

avatar waader
waader - comment - 6 Mar 2015

@test works with mysql and will probably work with postgresql and mssql. But there is another unrelated problem there. Thanks Kixo!

avatar waader waader - test_item - 6 Mar 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 1 Mar 2016

Please see #9269

avatar brianteeman brianteeman - change - 1 Mar 2016
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2016-03-01 14:07:28
Closed_By brianteeman
avatar brianteeman brianteeman - close - 1 Mar 2016
avatar brianteeman brianteeman - close - 1 Mar 2016
avatar wilsonge wilsonge - reference | bb47365 - 1 Mar 16

Add a Comment

Login with GitHub to post a comment