[#47807] - [6.1] update pre-update check for compat plugins
- Pending
- Medium
- Build: 6.1-dev
- # 47807
- Diff
- heelc29:6.1/joomlaupdate/precheck-compat
User tests: Successful: Unsuccessful:
Pull Request resolves # .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
- check if plugin exist before do further checks (to be safe)
- use dynamic names for compatibility plugins so that the code does not need to be updated for every new major version; the link in the language string remains fixed and must be adjusted
Testing Instructions
try to update a Joomla 6.2 to Joomla 7.0 nightlies (https://update.joomla.org/core/nightlies/next_major_list.xml)
Note: This PR is for 6.1-dev
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Pre-Update Check for Joomla 7 is displayed
Link to documentations
Please select:
- No documentation changes for guide.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate Language & Strings |
P.S.: A rebase to 6.2-dev would have the advantage that if we get it tested in time it can go into the upcoming 6.2.0-alpha1, which will be release on next Tuesday, May 26.
If we keep it for 6.1-dev, it would not make it into the 6.1.1 which will be released on the say day, as the 6.1.1 packages have already been built and are currently being tested ny the CMS Release Team. That would mean it would to into 6.1.2 and 6.2.0-alpha2 or alpha3.
@heelc29 Maybe you should mention in the description of this PR that you also fix that in 6.x the wrong plugins are checked. The checks were the same as in 5.4-dev for the compat and compat6 plugins, but in 6 they should check the compat6 and compat7 plugins. This is fixed with your PR.
By the way, we have the same issue in the libraries/src/Console/UpdateCoreCommand.php file for the CLI. I am preparing a PR to fix that in the same way as here in this PR.
As it is required to be on 6.2 (nightly or soon also 6.2.0-alpha1) for updating to 7.0, it would be sufficient to make this PR here for 6.2-dev.
See targetplatformversion here https://github.com/joomla/update.joomla.org/blob/master/www/core/nightlies/next_major_list.xml#L2 and targetplatform here https://github.com/joomla/update.joomla.org/blob/master/www/core/nightlies/next_major_extension.xml#L20
On the other hand if fixes the bug that we check for the wrong plugins in 6.1. I think we just haven't changed that because we did not have 7.0 nightlies until some month ago.
@tecpromotion @HLeithner I think it's on you to decide if you want that as bug fix or if we move it to 6.2-dev.