RTC Language Change bug PR-6.2-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
19 May 2026

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

  • check if plugin exist before do further checks (to be safe)
  • use dynamic names for compatibility plugins so that the code does not need to be updated for every new major version; the link in the language string remains fixed and must be adjusted

Testing Instructions

try to update a Joomla 6.2 to Joomla 7.0 nightlies (https://update.joomla.org/core/nightlies/next_major_list.xml)

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

Pre-Update Check for Joomla 7 is displayed
image

Link to documentations

Please select:

  • No documentation changes for guide.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 19 May 2026
avatar heelc29 heelc29 - change - 19 May 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 May 2026
Category Administration com_joomlaupdate Language & Strings
avatar richard67
richard67 - comment - 20 May 2026

Note: This PR is for 6.1-dev

As it is required to be on 6.2 (nightly or soon also 6.2.0-alpha1) for updating to 7.0, it would be sufficient to make this PR here for 6.2-dev.

See targetplatformversion here https://github.com/joomla/update.joomla.org/blob/master/www/core/nightlies/next_major_list.xml#L2 and targetplatform here https://github.com/joomla/update.joomla.org/blob/master/www/core/nightlies/next_major_extension.xml#L20

On the other hand if fixes the bug that we check for the wrong plugins in 6.1. I think we just haven't changed that because we did not have 7.0 nightlies until some month ago.

@tecpromotion @HLeithner I think it's on you to decide if you want that as bug fix or if we move it to 6.2-dev.

avatar richard67
richard67 - comment - 20 May 2026

P.S.: A rebase to 6.2-dev would have the advantage that if we get it tested in time it can go into the upcoming 6.2.0-alpha1, which will be release on next Tuesday, May 26.

If we keep it for 6.1-dev, it would not make it into the 6.1.1 which will be released on the say day, as the 6.1.1 packages have already been built and are currently being tested ny the CMS Release Team. That would mean it would to into 6.1.2 and 6.2.0-alpha2 or alpha3.

avatar richard67
richard67 - comment - 20 May 2026

@heelc29 Maybe you should mention in the description of this PR that you also fix that in 6.x the wrong plugins are checked. The checks were the same as in 5.4-dev for the compat and compat6 plugins, but in 6 they should check the compat6 and compat7 plugins. This is fixed with your PR.

By the way, we have the same issue in the libraries/src/Console/UpdateCoreCommand.php file for the CLI. I am preparing a PR to fix that in the same way as here in this PR.

avatar richard67 richard67 - change - 21 May 2026
Title
[6.1] update pre-update check for compat plugins
[6.2] update pre-update check for compat plugins
avatar richard67 richard67 - edited - 21 May 2026
avatar richard67 richard67 - change - 21 May 2026
Labels Added: Language Change PR-6.2-dev
avatar richard67 richard67 - change - 21 May 2026
The description was changed
avatar richard67 richard67 - edited - 21 May 2026
avatar richard67
richard67 - comment - 21 May 2026

@heelc29 I've allowed myself to rebase your PR to 6.2-dev as the issue definitely will not happen on 6.1-dev. The erroneous code is only run when updating to a new major, and updates to 7.0 require to be on 6.2 (nightly or soon alpha 1).

I had discussed it with the 6.2 release managers, and it will be great if we get it into the upcoming 6.2.0-alpha1, which is scheduled for next Tuesday.

avatar richard67 richard67 - test_item - 21 May 2026 - Tested successfully
avatar richard67
richard67 - comment - 21 May 2026

I have tested this item ✅ successfully on 41abf6b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47807.

avatar richard67
richard67 - comment - 21 May 2026

I have tested this item ✅ successfully on 41abf6b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47807.

avatar richard67
richard67 - comment - 21 May 2026

For the CLI see PR #47814 .

avatar dautrich dautrich - test_item - 21 May 2026 - Tested successfully
avatar dautrich
dautrich - comment - 21 May 2026

I have tested this item ✅ successfully on 41abf6b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47807.

avatar dautrich
dautrich - comment - 21 May 2026

I have tested this item ✅ successfully on 41abf6b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47807.

avatar richard67 richard67 - change - 21 May 2026
Status Pending Ready to Commit
Build 6.1-dev 6.2-dev
avatar richard67
richard67 - comment - 21 May 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47807.

avatar richard67
richard67 - comment - 21 May 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47807.

avatar heelc29
heelc29 - comment - 22 May 2026

@heelc29 I've allowed myself to rebase your PR to 6.2-dev as the issue definitely will not happen on 6.1-dev. The erroneous code is only run when updating to a new major, and updates to 7.0 require to be on 6.2 (nightly or soon alpha 1).

I had discussed it with the 6.2 release managers, and it will be great if we get it into the upcoming 6.2.0-alpha1, which is scheduled for next Tuesday.

Thanks

avatar charvimehradu charvimehradu - close - 23 May 2026
avatar charvimehradu charvimehradu - merge - 23 May 2026
avatar charvimehradu charvimehradu - change - 23 May 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-05-23 06:01:38
Closed_By charvimehradu
Labels Added: RTC bug
avatar charvimehradu
charvimehradu - comment - 23 May 2026

Thank you for your contribution as well to everyone who tested, reviewed, and took the time to go through the PR.

Add a Comment

Login with GitHub to post a comment