User tests: Successful: Unsuccessful:
Pull Request resolves #47675.
Changed data-nested="false" to data-nested="true" in three components that have nested hierarchies:
administrator/components/com_categories/tmpl/categories/default.phpadministrator/components/com_menus/tmpl/items/default.phpadministrator/components/com_modules/tmpl/modules/default.phpReason: These components have hierarchical structures indicated by data-parents and data-level attributes (or position-based grouping in Modules), so data-nested="true" correctly reflects their structure.
Go to Administrator → Components → Categories
Go to Administrator → Menus → Select any menu → Menu Items
Go to Administrator → Extensions → Modules
Go to Administrator → Content → Workflows and verify no regression
Ensure that:
Categories, Menu Items, and Modules components were marked with data-nested="false" despite having hierarchical structures.
The drag-drop functionality worked only because of a JavaScript bug where the string "false" is treated as truthy in JavaScript, accidentally enabling nested behavior even though the attribute said otherwise.
The data-nested attribute now correctly reflects the actual component structure:
data-nested="true" (parent-child hierarchy)data-nested="true" (parent-child hierarchy)data-nested="true" (position-based nesting)data-nested="false" (flat list, unchanged)This prepares the codebase for the JavaScript fix in PR #47689, which will properly convert string attribute values to booleans.
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_categories com_menus |
| Labels |
Added:
PR-5.4-dev
|
||
| Category | Administration com_categories com_menus | ⇒ | Administration com_categories com_menus com_modules |
@joomdonation Done!
I've added the change for Modules as well.
Updated PR now includes:
All three components now correctly reflect their nested structure
with data-nested="true".
Thanks for catching that!
| Title |
|
||||||
| Title |
|
||||||
@joomdonation Done!
I've added the change for Modules as well.
Updated PR now includes:
* Categories (parent-child hierarchy) * Menu Items (parent-child hierarchy) * Modules (position-based nesting)All three components now correctly reflect their nested structure with data-nested="true".
Thanks for catching that!
@RiteshGite Could you update the description of your PR? It still mentions modules as using false.
@richard67 Updated the PR description to include the Modules changes as well.
Thanks @RiteshGite. Could you please also make change to Modules as well ? Modules are actually nested, we can only drag and drop to change ordering of modules within same position, so we also need to
change data-nested="true", too