[#47780] - [5.4] Fix: Change data-nested='true' for nested components (Categories, Menu Items, Modules)
- Fixed in Code Base
- 18 Jul 2026
- Medium
- Build: 5.4-dev
- # 47780
- Diff
- RiteshGite:fix/data-nested-attributes
User tests: Successful: Unsuccessful:
Pull Request resolves #47675.
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Changed data-nested="false" to data-nested="true" in three components that have nested hierarchies:
administrator/components/com_categories/tmpl/categories/default.phpadministrator/components/com_menus/tmpl/items/default.phpadministrator/components/com_modules/tmpl/modules/default.php
Reason: These components have hierarchical structures indicated by data-parents and data-level attributes (or position-based grouping in Modules), so data-nested="true" correctly reflects their structure.
Affected Components
- Categories (parent-child hierarchy: has parent_id, data-parents, data-level)
- Menu Items (parent-child hierarchy: has parent_id, data-parents, data-level)
- Modules (position-based nesting: grouped by position)
Testing Instructions
-
Go to Administrator → Components → Categories
- Create a parent category with at least one child category
- Try drag-and-drop sorting on the Categories list
- Verify rows sort correctly and parent-child relationships are maintained
-
Go to Administrator → Menus → Select any menu → Menu Items
- Create a menu item with at least one child item
- Try drag-and-drop sorting on Menu Items list
- Verify it works and parent-child relationships are maintained
-
Go to Administrator → Extensions → Modules
- Try drag-and-drop sorting within the same position
- Verify modules can only be reordered within their position group
- Verify no regression in functionality
-
Go to Administrator → Content → Workflows and verify no regression
Ensure that:
- Drag-and-drop sorting works correctly for all three components
- Parent-child relationships are preserved in Categories and Menu Items
- Position-based ordering works in Modules
- Order is saved correctly
- No functional behavior is affected in other components
Actual result BEFORE applying this Pull Request
Categories, Menu Items, and Modules components were marked with data-nested="false" despite having hierarchical structures.
The drag-drop functionality worked only because of a JavaScript bug where the string "false" is treated as truthy in JavaScript, accidentally enabling nested behavior even though the attribute said otherwise.
Expected result AFTER applying this Pull Request
The data-nested attribute now correctly reflects the actual component structure:
- Categories →
data-nested="true"(parent-child hierarchy) - Menu Items →
data-nested="true"(parent-child hierarchy) - Modules →
data-nested="true"(position-based nesting) - Workflows →
data-nested="false"(flat list, unchanged)
This prepares the codebase for the JavaScript fix in PR #47689, which will properly convert string attribute values to booleans.
Link to documentations
- No documentation changes for guide.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_menus |
| Labels |
Added:
PR-5.4-dev
|
||
| Category | Administration com_categories com_menus | ⇒ | Administration com_categories com_menus com_modules |
@joomdonation Done!
I've added the change for Modules as well.
Updated PR now includes:
- Categories (parent-child hierarchy)
- Menu Items (parent-child hierarchy)
- Modules (position-based nesting)
All three components now correctly reflect their nested structure
with data-nested="true".
Thanks for catching that!
| Title |
|
||||||
| Title |
|
||||||
@joomdonation Done!
I've added the change for Modules as well.
Updated PR now includes:
* Categories (parent-child hierarchy) * Menu Items (parent-child hierarchy) * Modules (position-based nesting)All three components now correctly reflect their nested structure with data-nested="true".
Thanks for catching that!
@RiteshGite Could you update the description of your PR? It still mentions modules as using false.
@richard67 Updated the PR description to include the Modules changes as well.
Hi @joomdonation, could you please take a look at the latest changes when you get a chance? I’ve updated the PR description and included the Modules change as requested. Please let me know if anything else is needed from my side.
Thanks!
Hi @joomdonation, could you please take a look at the latest changes when you get a chance? I’ve updated the PR description and included the Modules change as requested. Please let me know if anything else is needed from my side.
Thanks!
I have tested this item ✅ successfully on 16e4c80
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47780.
I have tested this item ✅ successfully on 16e4c80
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47780.
I have tested this item ✅ successfully on 16e4c80
i can confirm that this PR chabnges it to data-nested=true and there is no change in bghaciour as a result of the change
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47780.
I have tested this item ✅ successfully on 16e4c80
i can confirm that this PR chabnges it to data-nested=true and there is no change in bghaciour as a result of the change
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47780.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47780.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47780.
| Labels |
Added:
RTC
bug
|
||
✅ Final test before merge with JBT
- preparation
- Created one parent category w/ one child and grandchild, one with two children and one with three children
- Created three menus, 1st w/ one menu item one child menu item, 2nd w/ two menu items and 3rd w/three
- Seen before PR
- Articles:Categories view contains
data-nested="false", but 1st level categories can be ordered by drag&drop, children and grandchildren cannot be ordered correctly - Menu view contains
data-nested="false"and menu entries can be ordered by drag&drop - Menu items view contains
data-nested="false", but menu item entries can be ordered by drag&drop - Site modules view contains
data-nested="false"AND entries cannot be ordered by drag&drop
- Articles:Categories view contains
- Applying PR with
gh pr checkout 47780- Articles:Categories view contains
data-nested="true"and 1st level categories can be ordered by drag&drop, children and grandchildren cannot be ordered correctly - Menu view contains
data-nested="false"menu entries can be ordered by drag&drop and the order is persistent - Menu items view contains
data-nested="true"and menu item entries can be ordered by drag&drop and the order is persistent, grandchild cannot be ordered correctly - Site modules view contains
data-nested="true"and entries can be ordered by drag&drop and the order is persistent - Installed Blog sample data, workflows view contains
data-nested="false", entries can be ordered and the order is persistent
- Articles:Categories view contains
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-07-18 15:27:38 |
| Closed_By | ⇒ | muhme |
Thank you very much @RiteshGite for your first time contribution 👍
Thanks to @joomdonation @richard67 for support. Thanks to @CSGoat0 and @brianteeman for testing.
Thanks @RiteshGite. Could you please also make change to Modules as well ? Modules are actually nested, we can only drag and drop to change ordering of modules within same position, so we also need to
change data-nested="true", too