[#47729] - [5.4] Light mode: dismiss button
- Fixed in Code Base
- 5 May 2026
- Medium
- Build: 5.4-dev
- # 47729
- Diff
- brianteeman:media_close
User tests: Successful: Unsuccessful:
Pull Request resolves #47728 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
use the var --light for the color of the close X
Testing Instructions
Apply pr and npm i (or use a prebuilt package)
In the media manager open an image for preview and check the close icon
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.4-dev
|
||
I have tested this item ✅ successfully on 8ce7f16
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47729.
I have tested this item ✅ successfully on 8ce7f16
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47729.
I have tested this item ✅ successfully on 8ce7f16
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47729.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47729.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47729.
| Labels |
Added:
RTC
|
||
✅ Final test before merge using JBT
- Seen grey image close button in grey overlay before PR
- Applied PR with Patch Tester and
npm run build:css- Close button is now white and clear visible in light mode
- Close button still white and clear visible in dark mode
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-05-05 14:26:00 |
| Closed_By | ⇒ | muhme | |
| Labels |
Added:
bug
|
||
Thank you very much @brianteeman for your contribution. Thank you @krishnagandhicode for support. Thanks to @krishnagandhicode and @chmst for testing.
Thanks
I have tested this item ✅ successfully on 8ce7f16
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47729.