[#47707] - [6.2] Fix Save as Copy for access levels by generating unique title
- Ready to Commit
- Medium
- Build: 5.4-dev
- # 47707
- Diff
- krishnagandhicode:fixForSaveAsCopy
User tests: Successful: Unsuccessful:
Pull Request resolves #47706
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
This follows the same pattern already used for User Groups ie. GroupModel::generateGroupTitle since J3.3.7
Testing Instructions
Navigate to:
Administrator > users > Access Levels
click on any existing access level (eg Special) to edit it
now click the dropdown arrow next to Save & Close and select "Save as Copy"
Actual result BEFORE applying this Pull Request
Error message: "Save failed with the following error: Level with the name "Special" already exists." and no copy is created
Expected result AFTER applying this Pull Request
A new access level is created with an incremented title eg "Special (2)" , similar to how User Groups, Articles etc handle "Save as Copy"
Also if you Repeat "Save as Copy" for newly created Special (2) it creates Special (3).
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users |
I have tested this item ✅ successfully on 38ea60a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47707.
Hi @krishnagandhicode
That’s a sensible solution. Thank you.
| Labels |
Added:
PR-5.4-dev
|
||
I have tested this item ✅ successfully on c461848
I have tested this successfully - thanks @krishnagandhicode!
I tried having an access level with already a number at the beginning, and one at the end in its name and the results were as expected, tried with and without User Groups defined.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47707.
I have tested this item ✅ successfully on c461848
I have tested this successfully - thanks @krishnagandhicode!
I tried having an access level with already a number at the beginning, and one at the end in its name and the results were as expected, tried with and without User Groups defined.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47707.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47707.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47707.
| Labels |
Added:
RTC
|
||
@krishnagandhicode Thanks for this PR. We just have discussed it in the CMS Maintenance Team and came to the conclusion that it is not really a bug fix but a new feature when interpreting the rules here strictly: https://github.com/joomla/joomla-cms#which-branch-should-my-pull-request-target
Could you rebase this PR to 6.2-dev?
If yes and you rebase, it can happen that GitHub shows unrelated changes until release managers will do the upmerges from 5.4-dev into the upper branches. This just for your information so you won't be confused.
Thanks in advance.
Thanks for the review @richard67,
I just wanted to share my perspective : the "Save as Copy" button has been there ALREADY for the Access Level edit view but it simply doesn't work because the model was missing the title generaton logic, also This same functionality already works for articles, modules, and other areas in Joomla.
This PR doesn't really add something new - it just makes an existing button work as expected. That said, I respect youer experience and the team's decision. If you still feel it should target 6.2-dev, I'm happy to do the rebase. Just let me know :)
Thanks for the review @richard67, I just wanted to share my perspective : the "Save as Copy" button has been there ALREADY for the Access Level edit view but it simply doesn't work because the model was missing the title generaton logic
The button works. You just have to remember that you have to change the title before using the button.
This same functionality already works for articles, modules, and other areas in Joomla.
A similar PR for the alias of smart search filters was once merged and later reverted, see PRs #46081 and #46453 .
If you still feel it should target 6.2-dev, I'm happy to do the rebase. Just let me know :)
Yes, please rebase.
Thanks in advance.
| Title |
|
||||||
| Category | Administration com_users | ⇒ | Administration com_installer com_joomlaupdate com_users Language & Strings Installation |
| Labels |
Added:
Language Change
PR-6.2-dev
|
||
![avatar github-actions[bot]](/images/avatars/github-actions[bot].png)
This pull request has conflicts, please resolve those before we can evaluate the pull request.
| Labels |
Added:
Conflicting Files
|
||
| Category | Administration com_users com_installer com_joomlaupdate Language & Strings Installation | ⇒ | Administration com_users |
@richard67 Thanks for the explanation.
Rebase is done.
I have tested this item ✅ successfully on 38ea60a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47707.