[#47700] - fix: Replace print_r with json_encode for debug logging in BaseController
- Closed
- 27 Apr 2026
- Medium
- Build: 5.4-dev
- # 47700
- Diff
- Mahesh-Gite-28:fix/replace-print_r-with-json_encode-in-base-controller
User tests: Successful: Unsuccessful:
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Replace str_replace("\n", ' ', print_r($values, 1)) with
json_encode($values, JSON_UNESCAPED_SLASHES) in three JDEBUG-only
debug log statements inside BaseController.
Affected methods:
- checkEditId()
- holdEditId()
- releaseEditId()
Testing Instructions
- Enable JDEBUG in Joomla configuration.
- Trigger actions that call:
checkEditId()
holdEditId()
releaseEditId() - Verify log output.
Ensure that:
- Logs are generated correctly
- Output is in JSON format
- No functional behavior is affected
Actual result BEFORE applying this Pull Request
Debug logs used print_r() combined with str_replace(),
producing verbose and less readable output with unnecessary processing overhead.
Expected result AFTER applying this Pull Request
Debug logs use json_encode(), producing cleaner, compact, and
more efficient single-line output without extra processing.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
![avatar github-actions[bot]](/images/avatars/github-actions[bot].png)
This pull request has conflicts, please resolve those before we can evaluate the pull request.
| Labels |
Added:
Conflicting Files
PR-5.4-dev
|
||
| Category | Libraries | ⇒ | Administration com_installer com_joomlaupdate Language & Strings Layout Libraries |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-04-27 10:12:39 |
| Closed_By | ⇒ | Mahesh-Gite-28 | |
| Labels |
Added:
Language Change
PR-6.2-dev
Removed: Conflicting Files |
||
Thanks for your guidance. I have updated the pull request to target 6.2-dev and resolved the merge conflicts.
Thanks for your guidance. I have updated the pull request to target 6.2-dev and resolved the merge conflicts.
https://github.com/joomla/joomla-cms#which-branch-should-my-pull-request-target