[#47697] - [5.4] Move mod_menu language load after client_id resolution in ItemsModel
- Fixed in Code Base
- 28 Apr 2026
- Medium
- Build: 5.4-dev
- # 47697
- Diff
- krishnagandhicode:fixFor47696
User tests: Successful: Unsuccessful:
Pull Request resolves #47696
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
In ItemsModel inside populateState() the mod_menu language file load was placed before the menutype resolution logic that determines the final client_id. Moved it to after getUserStateFromRequest() so it uses the final resolved client_id.
Testing Instructions
Navigate to:
Menus -> manage > switch the filter/dropdown to Administrator
mow create a new menu with Preset set to "System Dashboard"
then Save & Close:
now look in Menus -> at the bottom you will see the custom admin menu you just created > click on it.
Actual result BEFORE applying this Pull Request
Titles show as raw language constants like MOD_MENU_CONFIGURATION, MOD_MENU_CLEAR_CACHE, etc. on first load. Refreshing the page fixes it.
Expected result AFTER applying this Pull Request
itles show correctly as "Global Configuration", "Clear Cache", etc. right away — no refresh needed.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
So, is that not fixed in J!5.4.5? Are you asking me to attempt to repeat the steps used above? I can clone the site and give it a try if so.
Confirmed on J!5.4.5.
Confirmed on J!5.4.5. Made the same changes and it resolved the issue.
I have tested this item ✅ successfully on b8c189d
Hi @krishnagandhicode, thanks for the fix, easy one to test! :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47697.
I have tested this item ✅ successfully on b8c189d
Hi @krishnagandhicode, thanks for the fix, easy one to test! :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47697.
| Status | Pending | ⇒ | Ready to Commit |
I set the test result for @bascherz test manually. RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47697.
I set the test result for @bascherz test manually. RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47697.
| Labels |
Added:
RTC
bug
PR-5.4-dev
|
||
✅ Final test before merge using JBT
- Seen language constants before PR
- As this problem only occurs on the first view, you need to log out and log in again to reproduce it a 2nd time
- Applied PR with Patch Tester, then logged out and login again
- The translated language constants are displayed on the first view
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-04-28 13:12:59 |
| Closed_By | ⇒ | muhme |
✅ Final test before merge using JBT
Seen language constants before PR
- As this problem only occurs on the first view, you need to log out and log in again to reproduce it a 2nd time
Applied PR with Patch Tester, then logged out and login again
The translated language constants are displayed on the first view
In my case, I was able to reproduce the issue by simply clicking on a different menu (e.g., Main) in the admin menu. Did not have to logout and back in.
Thank you very much @krishnagandhicode for your contribution. Thanks to @joomdonation for support. Thanks to @bascherz and @exlemor for testing.
Thanks Heiko for merge, Thanks to all who helped testing : )
So, is that not fixed in J!5.4.5? Are you asking me to attempt to repeat the steps used above? I can clone the site and give it a try if so.