PR-6.1-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
26 Apr 2026

Pull Request resolves #47693.

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Currently, if version history is enabled for a component, every view extends FormView class from that component will have Versions button shown, even if that view does not really support versions history. This PR just fixes that wrong behavior. The button will only be shown if:

  • Versions History is enabled for the component
  • The model associated with the view implements VersionableModelInterface (the modern version history implement supported from 6.0)
  • Or the associated table implements VersionableModelInterface

Testing Instructions

  • Enable Versions History for com_content. Then edit an article and make sure Versions button is still being displayed
  • Disable Versions History for com_conent. Then edit an article and make sure Versions button is not being displayed

Basically, make sure versions history still work with this PR applied. Then we will wait for @Ruud68 test confirms that it works well for his custom extension

Actual result BEFORE applying this Pull Request

Versions button is always shown for every views extends FormView class even if that view does not support versions history

Expected result AFTER applying this Pull Request

Versions button is only shown for views extends FormView class if that view support versions history

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomdonation joomdonation - open - 26 Apr 2026
avatar joomdonation joomdonation - change - 26 Apr 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Apr 2026
Category Libraries
avatar joomdonation joomdonation - change - 26 Apr 2026
Labels Added: PR-6.1-dev
609eba2 26 Apr 2026 avatar joomdonation CS
avatar exlemor exlemor - test_item - 27 Apr 2026 - Tested successfully
avatar exlemor
exlemor - comment - 27 Apr 2026

I have tested this item ✅ successfully on 609eba2

I have successfully tested this! Thanks @joomdonation!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47694.

avatar exlemor
exlemor - comment - 27 Apr 2026

I have tested this item ✅ successfully on 609eba2

I have successfully tested this! Thanks @joomdonation!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47694.

avatar Ruud68
Ruud68 - comment - 27 Apr 2026

Hi @joomdonation thanks for picking this up and creating the PR for it.

Just tested it and it works, would suggest one small change:
you have created a method responsible for checking if a view can / should have versionhistory enabled.
This actual check is now currently 'split'. My suggestion would be to add $this->state->get('params')->get('save_history', 0) check also in the protected function supportVersionHistory() as that would make it more 'clean' IMO.

avatar joomdonation
joomdonation - comment - 27 Apr 2026

Thanks @Ruud68. Implemented the suggested change, also renaming the method to fit the code better. Could you please check it again? If it works, please report your test result so that the PR can be merged. Thanks

Add a Comment

Login with GitHub to post a comment