User tests: Successful: Unsuccessful:
Problem
JGrid action buttons currently do not support custom data attributes. This limits developers from attaching additional metadata to action buttons for advanced JavaScript handling or custom UI behavior.
Solution
This PR introduces support for a data-item-custom attribute through an optional custom array in the JGrid action helper.
This allows developers to pass extra metadata to grid action buttons without modifying core logic or breaking existing functionality.
| Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries |
This is now the fourth time you have been asked to use the pr template. If you continue to submit PR without doing so I will ask for your access to be removed
There was a very good reason why you were given a template to complete when you submitted this PR. Please update your pr with the required details or this will have to be closed. you can find the template here https://github.com/joomla/joomla-cms/blob/5.4-dev/.github/PULL_REQUEST_TEMPLATE.md
Sorry for the repeated updates and for not following the PR template properly earlier. I am still learning the contribution process for Joomla and I understand the requirements now. I have updated the PR with all the required sections. Thank you for your patience and guidance.
Sorry for the repeated updates and for not following the PR template properly earlier. I am still learning the contribution process for Joomla and I understand the requirements now. I have updated the PR with all the required sections. Thank you for your patience and guidance.
no you have not and please update all your existing PR and resolved the comments on each one
New features have to bebproposed for the 6.2-dev branch. See also https://github.com/joomla/joomla-cms#which-branch-should-my-pull-request-target
New features have to be proposed for the 6.2-dev branch. See also https://github.com/joomla/joomla-cms#which-branch-should-my-pull-request-target
| Labels |
Added:
PR-5.4-dev
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-04-26 10:28:39 |
| Closed_By | ⇒ | richard67 |
Please use the Pull Request-Template.