Conflicting Files PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar jiteshkhatri11
jiteshkhatri11
22 Apr 2026

Summary

Adds support for passing a custom data attribute (data-item-custom) in JGrid helper methods.

Changes

  • Added custom option in JGrid::action()
  • Added custom option in JGrid::published()
  • Safe JSON encoding with error handling
  • Fully backward compatible

Example usage

JGrid::action($i, 'publish', [
    'custom' => ['id' => 123, 'type' => 'article']
]);
avatar jiteshkhatri11 jiteshkhatri11 - open - 22 Apr 2026
avatar jiteshkhatri11 jiteshkhatri11 - change - 22 Apr 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2026
Category Repository Administration com_admin SQL
avatar github-actions[bot]
github-actions[bot] - comment - 22 Apr 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

avatar brianteeman
brianteeman - comment - 23 Apr 2026

Please close

avatar muhme muhme - change - 24 Apr 2026
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2026-04-24 05:29:31
Closed_By muhme
Labels Added: Conflicting Files PR-5.4-dev
avatar muhme muhme - close - 24 Apr 2026
avatar muhme
muhme - comment - 24 Apr 2026

Thank you for your contribution @jiteshkhatri11. Unfortunately, this pull request cannot be reviewed in its current state.

It does not use the required PR template, and it contains 1,887 changed files. Please use the pull request template in full and ensure that a PR includes only the files directly related to your intended changes.

For these reasons, this PR is being closed. We would be happy to review a new submission once it has been prepared accordingly.

Add a Comment

Login with GitHub to post a comment