If records are not present then pop up message and confirmation message should not be displayed.
If records are not present then pop up message and confirmation message is displayed.
PHP Built On Windows NT 6.2 build 9200
Database Version 5.6.12-log
Database Collation utf8_general_ci
PHP Version 5.4.12
Web Server Apache/2.4.4 (Win64) PHP/5.4.12
WebServer to PHP Interface apache2handler
Joomla! Version Joomla! 3.3.7-dev Development [ Ember ] 01-October-2014 02:00 GMT
Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent Mozilla/5.0 (Windows NT 6.1; rv:32.0) Gecko/20100101 Firefox/32.0
Priority | Critical | ⇒ | Medium |
Status | New | ⇒ | Confirmed |
Bug is reproduced. Confirmed
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4765.
Bug Fix -
Made changes in administrator\components\com_banners\controllers\tracks.php
and
administrator\language\en-GB\en-GB.com_banners.ini
1) In administrator\components\com_banners\controllers\tracks.php change the code from
else
{
$this->setMessage(JText::plural('COM_BANNERS_TRACKS_N_ITEMS_DELETED', $count));
}
to
else if(count > 0)
{
$this->setMessage(JText::plural('COM_BANNERS_TRACKS_N_ITEMS_DELETED', $count));
}
else{
$this->setMessage(JText::plural('COM_BANNERS_TRACKS_0_ITEMS_DELETED'));
}
2) In administrator\language\en-GB\en-GB.com_banners.ini added
COM_BANNERS_TRACKS_0_ITEMS_DELETED = "No Tracks to Delete"
Still to commit the changes
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4765.
When you have submitted a pull request please link to it here - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4765.
Shouldn't we hide the Delete and Export buttons if there are no tracks?
The concept of hiding buttons when they can not be used as been rejected
(unfortunately)
On 20 October 2014 12:04, Tuan Pham Ngoc notifications@github.com wrote:
Shouldn't we hide the Delete and Export buttons if there are no tracks?
—
Reply to this email directly or view it on GitHub
#4765 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Oh, OK. Thanks @brianteeman for letting me know.
Labels |
Added:
?
|
Status | Confirmed | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-04-30 12:25:10 |
Closed_By | ⇒ | brianteeman |
See #6871
Setting to confirmed and setting the correct priority level as per http://docs.joomla.org/Priority