[#47642] - [5.4] Correct aria-posinset to start from 1 [a11y]
- Fixed in Code Base
- 28 Apr 2026
- Medium
- Build: 5.4-dev
- # 47642
- Diff
- brianteeman:posinset
User tests: Successful: Unsuccessful:
Pull Request resolves # .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
ARIA defines:
aria-posinset → position in the set
aria-setsize → total number of items
Both are human-relevant, not zero-based programming indexes.
So valid output should be:
| item | index | aria-posinset |
|---|---|---|
| first | 0 | 1 |
| second | 1 | 2 |
| third | 2 | 3 |
Testing Instructions
In media manager create some folders and then check the values of the a links of each tree item (directory name)
It should be telling you which item (posinset) the link is in the set (setsize)
This is an npm change so you either need to npm ci or use a pre-built package
Actual result BEFORE applying this Pull Request
the links are zero-based so the first link is
<a role="treeitem" aria-level="2" aria-setsize="6" aria-posinset="0" tabindex="-1"><span class="item-icon"><span class="icon-folder"></span></span><span class="item-name">banners</span></a>
and the last one will also have a posinset value of 1 less than the setsize
<a role="treeitem" aria-level="2" aria-setsize="6" aria-posinset="5" tabindex="-1"><span class="item-icon"><span class="icon-folder"></span></span><span class="item-name">banners</span></a>
Expected result AFTER applying this Pull Request
the posinset correctly starts at 1 and ends with the value=setsize
<a role="treeitem" aria-level="2" aria-setsize="6" aria-posinset="1" tabindex="-1"><span class="item-icon"><span class="icon-folder"></span></span><span class="item-name">banners</span></a>
<a role="treeitem" aria-level="2" aria-setsize="6" aria-posinset="6" tabindex="-1"><span class="item-icon"><span class="icon-folder"></span></span><span class="item-name">banners</span></a>
it is debatable if we even need this as it wold normallyb only be used if the entire set is not displayed. But as we do already display the posinset it should at a minimum have the correct values
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.4-dev
|
||
I have tested this item ✅ successfully on b0fb97e
I have tested this successfully during April 24th, 2026 - PR Testing Session. Thanks @brianteeman!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47642.
I have tested this item ✅ successfully on b0fb97e
Checked the first and last one. all +1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47642.
I have tested this item ✅ successfully on b0fb97e
Checked the first and last one. all +1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47642.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47642.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47642.
@brianteeman Just because I'm curious: Do you have any idea why GitHub shows the complete code of the file as changes, even if there is not really a visible change?
@richard67 i have no idea. i see it sometimes with some filetypes
| Labels |
Added:
RTC
a11y
|
||
Do you have any idea why GitHub shows the complete code of the file as changes, even if there is not really a visible change?
Reason is that the modified new file uses CRLF (carriage return + linefeed) line terminators, the original file use only LF. If you change the new file to Unix-format linefeed only, you can compare and see the difference is only:
18c18
< :aria-posinset="index"
---
> :aria-posinset="index + 1"
@brianteeman Could you commit the file with linefeeds only?
my git client is configured to do that - dont know why it didnt this time. should be ok now
✅ Final test before merge using JBT
- Seen
aria-posinset="0"before PR - Applied PR with Patch Tester and
npm ci - The first entry shows
aria-posinset=‘1’and the following folders increment the number
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-04-28 08:48:16 |
| Closed_By | ⇒ | muhme |
Thank you very much @brianteeman for your contribution. Thanks to @exlemor and @ThomasFinnern for testing.
thanks
I have tested this item ✅ successfully on b0fb97e
I have tested this successfully during April 24th, 2026 - PR Testing Session. Thanks @brianteeman!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47642.